Generator parts: target a specific brush of a generator, or all of a kind

オープン
  • 何か問題がありますか？
#245 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
csharp, unity
領域
design, game-dev

調査の方向性

Start by reading the related issues #165, #242, #183, and #237, then trace how generators create brushes and how decals and trims resolve their targets. Check whether each generator can tag brushes consistently and how polygon decal corner anchors fit. Done means generators expose named brush parts, targets can select a part by role and index or apply to all matching parts, and decals and trims follow those targets as described.

索引モデルが issue の本文から書いたものです。

説明

Decals (and anything else that targets a surface) can't say which brush of a generator they mean. A target is the generator plus a surface number, which resolves to the first brush with that surface (depth first). On a generator made of several brushes (stairs, and any other) a trim or targeted decal lands on the wrong brush, or doesn't draw.

This has to work for every generator, and each generator handles it itself: it knows what its brushes are.

Parts

  • Each generator declares the roles of its brushes (for linear stairs: Step, Landing, Side; for spiral stairs: Step, Column, RailTop; ...), each with a display name for the UI.
  • Every brush it makes is tagged with a part key: (role, index), small ints, set when the brushes are made. Names are never compared at runtime.
  • On rebuild the generator fills a table from part key to brush, so resolving a target is a lookup, not a search.
  • A generator that declares nothing gets one default role ("Brush") indexed in build order, so every generator works the same way.

Targets

A target becomes: generator, surface number, role, index, and how the index counts:

  • From start or from end: picked from the nearer end when placed, so a decal on the top step stays on the top step when steps are added or removed.
  • All: every brush of that role.

Placing (dropping a decal, picking a trim's edge) fills these in from the brush hit. The decal inspector shows the part by name ("Linear Stairs > Step 3, from bottom") and lets the count (from start, from end, all) be changed.

Automatically apply to multiple targets

  • Box decal on all steps: one decal component; the decal manager adds a copy per matching brush, at the same place relative to each brush's surface, like it splits a trim into pieces now.
  • Trim along a whole edge: the chain is the same edge on every brush of the role, in index order, so a trim follows e.g. the whole curved top edge of the rails, and keeps doing so when segments are added.
  • Could work with decals by dropping them while holding shift, on particular generator specific edges or surfaces.

Changes

  • When a part is gone (fewer steps than the index), the target draws nothing and keeps its data, as now.
  • Robust to adding brushes: targets keep naming the same part.

To check first

  • That every generator builds its brushes in an order it can tag consistently.
  • How polygon decals' corner anchors fit in.

Related: #165, #242, #183, #237.

主要言語
C#
スター
135
フォーク
15
平均マージ
33分
マージ済み PR（30日）
122

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

RadicalCSG/com.chisel のほかの issue

RadicalCSG/com.chisel の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。