Assessment: Include input columns in results
メンテナーはふだん 1 日以内に返信
評価
この issue はまだ評価されていません。
説明
Is your feature request related to a problem?
The assessment results sheet currently shows only the output columns for runs with more than 100 rows, leaving out the submission's input columns. This omission prevents reviewers from understanding the basis for the scores given.
Describe the solution you'd like
- Frontend-only approach: Use the existing endpoint with
include_signed_url=Trueto fetch and parse the full file from S3, eliminating the row limit without backend changes. - Backend solution: Modify the backend to include full source rows in
items[].inputon the assessment results, allowing for direct data joining. - Increase the limit: Change the endpoint validation to allow more than 100 rows, although this alters the intended design of the preview endpoint.
Option 2 is preferred for durability; option 1 offers a quick frontend fix.
Acceptance
- Source columns for a run of 1000 rows are displayed in the results sheet and CSV download.
- Source columns appear before output columns.
- Pre-filter-rejected rows show source columns with their verdicts.
- No 422 errors when accessing results for any run size.
Original issue
Problem
The assessment results sheet shows only the columns a run produced. The submission's own columns — including the ones the config never mapped — are absent, so a reviewer cannot see the input a score was given for.
PR #285 joins the submission's rows back onto the results by row_index, but it can only do so for runs of 100 rows or fewer.
Why 100
GET /api/v1/assessment/datasets/{dataset_id} validates limit_rows with ge=1, le=100:
Anything above the cap returns 422. The endpoint is a preview by design — it downloads and parses the whole file from S3 on each call, which is what the cap protects.
PR #285 adds no cap of its own — it requests exactly the run's row count so that this endpoint stays the single place the ceiling lives, and raising le= needs no matching frontend change. Until that happens, a run above 100 rows 422s and silently joins nothing: no error, no source columns, just the output-only sheet we have today.
Options
- Signed URL, frontend-only. The same endpoint already serves
include_signed_url=True. The frontend fetches the file from S3 and parses it with thexlsxdependency already inpackage.json. No cap, no backend change. Needs CORS on the bucket to allow browser reads, and pulls the xlsx bundle onto the results route. - Backend returns the full source row in
items[].inputon the assessment results. Cleanest — the join happens where the data already is, and the frontend keeps doing what it does now. Backend work. - Raise
le=100. One line, and with no frontend cap in the way it takes effect immediately. It does turn a deliberately bounded preview endpoint into a bulk-data one, so it is a stopgap rather than the end state.
Option 2 is the most durable; option 1 unblocks the frontend without backend changes.
Acceptance
- A run of 1000 rows shows its source columns in the results sheet and the CSV download
- Source columns come before the run's output columns
- Pre-filter-rejected rows still show their source columns alongside the verdict
- No 422 in the network log when opening results for a run of any size
Notes
Column ordering is handled separately in PR #285 — output columns now follow the config's output_schema order rather than a first-seen union across rows, which is why they used to shuffle between runs.
- 主要言語
- TypeScript
- スター
- 1
- フォーク
- 0
- 平均マージ
- 19時間 4分
- マージ済み PR（30日）
- 6
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドなし
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
ProjectTech4DevAI/kaapi-frontend のほかの issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
ProjectTech4DevAI/kaapi-frontend#267 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
ProjectTech4DevAI/kaapi-frontend#266 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
ProjectTech4DevAI/kaapi-frontend#261 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
ProjectTech4DevAI/kaapi-frontend#258 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
ProjectTech4DevAI/kaapi-frontend#274 ·
メンテナーはふだん 1 日以内に返信
ProjectTech4DevAI/kaapi-frontend の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
aiko-chan-ai/DiscordBotClient#380 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
vercel/ai-elements#507 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 半日 初心者へのやさしさ 84/100
anaclumos/qa-interns#148 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信