Assessment: Include input columns in results
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Is your feature request related to a problem?
The assessment results sheet currently shows only the output columns for runs with more than 100 rows, leaving out the submission's input columns. This omission prevents reviewers from understanding the basis for the scores given.
Describe the solution you'd like
- Frontend-only approach: Use the existing endpoint with
include_signed_url=Trueto fetch and parse the full file from S3, eliminating the row limit without backend changes. - Backend solution: Modify the backend to include full source rows in
items[].inputon the assessment results, allowing for direct data joining. - Increase the limit: Change the endpoint validation to allow more than 100 rows, although this alters the intended design of the preview endpoint.
Option 2 is preferred for durability; option 1 offers a quick frontend fix.
Acceptance
- Source columns for a run of 1000 rows are displayed in the results sheet and CSV download.
- Source columns appear before output columns.
- Pre-filter-rejected rows show source columns with their verdicts.
- No 422 errors when accessing results for any run size.
Original issue
Problem
The assessment results sheet shows only the columns a run produced. The submission's own columns — including the ones the config never mapped — are absent, so a reviewer cannot see the input a score was given for.
PR #285 joins the submission's rows back onto the results by row_index, but it can only do so for runs of 100 rows or fewer.
Why 100
GET /api/v1/assessment/datasets/{dataset_id} validates limit_rows with ge=1, le=100:
Anything above the cap returns 422. The endpoint is a preview by design — it downloads and parses the whole file from S3 on each call, which is what the cap protects.
PR #285 adds no cap of its own — it requests exactly the run's row count so that this endpoint stays the single place the ceiling lives, and raising le= needs no matching frontend change. Until that happens, a run above 100 rows 422s and silently joins nothing: no error, no source columns, just the output-only sheet we have today.
Options
- Signed URL, frontend-only. The same endpoint already serves
include_signed_url=True. The frontend fetches the file from S3 and parses it with thexlsxdependency already inpackage.json. No cap, no backend change. Needs CORS on the bucket to allow browser reads, and pulls the xlsx bundle onto the results route. - Backend returns the full source row in
items[].inputon the assessment results. Cleanest — the join happens where the data already is, and the frontend keeps doing what it does now. Backend work. - Raise
le=100. One line, and with no frontend cap in the way it takes effect immediately. It does turn a deliberately bounded preview endpoint into a bulk-data one, so it is a stopgap rather than the end state.
Option 2 is the most durable; option 1 unblocks the frontend without backend changes.
Acceptance
- A run of 1000 rows shows its source columns in the results sheet and the CSV download
- Source columns come before the run's output columns
- Pre-filter-rejected rows still show their source columns alongside the verdict
- No 422 in the network log when opening results for a run of any size
Notes
Column ordering is handled separately in PR #285 — output columns now follow the config's output_schema order rather than a first-seen union across rows, which is why they used to shuffle between runs.
- Lingua principale
- TypeScript
- Stelle
- 1
- Fork
- 0
- Merge medio
- 19h 4m
- PR unite (30g)
- 6
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di ProjectTech4DevAI/kaapi-frontend
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
ProjectTech4DevAI/kaapi-frontend#266 · 1 commento ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
ProjectTech4DevAI/kaapi-frontend#258 · 3 commenti ·
-
enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
Tutte le issue di ProjectTech4DevAI/kaapi-frontend
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
ontola/atomic-server#1625 ·
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
melgarafael/DeskcommCRM#1451 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
-
bug via-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
bot:ai-assisted component:compact-js status:untriaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
midnightntwrk/midnight-sdk#403 ·