Worker resourceLimits are not enforced while DevTools has the Debugger domain enabled

オープン
#2,107 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp

調査の方向性

Start in WorkerWrapper::OnNearHeapLimit and PrepareV8Runtime, then trace how the worker inspector session enables Debugger and how V8Debugger::enable and disable manage heap-limit callbacks. Reproduce with a debug build and a worker using resourceLimits; check that the parent receives the heap-limit error and the worker terminates after any intended debugger pause or resume.

索引モデルが issue の本文から書いたものです。

説明

Summary

In a debug build, once a DevTools session enables the Debugger domain on a worker target, that worker's resourceLimits stop being enforced and the parent never receives the heap-limit error.

Why

WorkerWrapper::OnNearHeapLimit is registered with AddNearHeapLimitCallback in PrepareV8Runtime. It reports ERR_WORKER_OUT_OF_MEMORY to the parent and terminates the worker. V8 only invokes the most recently added near-heap-limit callback (Heap::InvokeNearHeapLimitCallback calls near_heap_limit_callbacks_.back(), src/heap/heap.cc). V8Debugger::enable adds its own callback (src/inspector/v8-debugger.cc), which shadows the worker's for as long as the Debugger domain stays enabled. That callback:

  • schedules an OOM break (BreakReason::kOOM), and
  • returns HeapLimitForDebugging(initial_heap_limit), which raises the limit well past the configured maxOldGenerationSizeMb.

So while a debugger is attached to the worker, the worker either pauses on OOM in DevTools or keeps running above its cap. Either way OnNearHeapLimit never runs: the parent gets no error event, terminate/exit never follow, and code that relies on resourceLimits to contain a runaway worker behaves differently under the debugger than without it. Detaching restores the worker's callback (V8Debugger::disable removes the debugger's).

Release builds are unaffected (no inspector), and so are debug builds with no DevTools session, or with one that never enables Debugger on the worker target.

Expected

Pausing on OOM while debugging is reasonable and matches Chrome. But after the user resumes (or if the debugger's raised limit is also exhausted), the worker should still be reported and terminated as it is without a debugger. Possible directions:

  • Re-register OnNearHeapLimit after the worker's inspector session enables Debugger, so it stays last, and decide explicitly whether to break first.
  • Or chain: keep the debugger's break, but have the worker's handler run on resume, or once the debug allowance is exhausted.
Repro (sketch)
  1. Debug build of an app with a worker created with resourceLimits: { maxOldGenerationSizeMb: 16 } whose script allocates until it runs out of memory.
  2. Without DevTools: the parent gets the heap-limit error, and the worker ends.
  3. Attach Chrome DevTools to the worker target (which enables Debugger) and rerun: no error reaches the parent. The worker pauses on OOM, or, after resuming, keeps allocating past 16 MB.

Found while reviewing #2070.

主要言語
C++
スター
565
フォーク
147
平均マージ
1日 2時間
マージ済み PR(30日)
27

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

NativeScript/android のほかの issue

NativeScript/android の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。