Worker resourceLimits are not enforced while DevTools has the Debugger domain enabled
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- cpp
- Área
- backend, mobile-dev
Línea de trabajo
Start in WorkerWrapper::OnNearHeapLimit and PrepareV8Runtime, then trace how the worker inspector session enables Debugger and how V8Debugger::enable and disable manage heap-limit callbacks. Reproduce with a debug build and a worker using resourceLimits; check that the parent receives the heap-limit error and the worker terminates after any intended debugger pause or resume.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
In a debug build, once a DevTools session enables the Debugger domain on a worker target, that worker's resourceLimits stop being enforced and the parent never receives the heap-limit error.
Why
WorkerWrapper::OnNearHeapLimit is registered with AddNearHeapLimitCallback in PrepareV8Runtime. It reports ERR_WORKER_OUT_OF_MEMORY to the parent and terminates the worker. V8 only invokes the most recently added near-heap-limit callback (Heap::InvokeNearHeapLimitCallback calls near_heap_limit_callbacks_.back(), src/heap/heap.cc). V8Debugger::enable adds its own callback (src/inspector/v8-debugger.cc), which shadows the worker's for as long as the Debugger domain stays enabled. That callback:
- schedules an OOM break (
BreakReason::kOOM), and - returns
HeapLimitForDebugging(initial_heap_limit), which raises the limit well past the configuredmaxOldGenerationSizeMb.
So while a debugger is attached to the worker, the worker either pauses on OOM in DevTools or keeps running above its cap. Either way OnNearHeapLimit never runs: the parent gets no error event, terminate/exit never follow, and code that relies on resourceLimits to contain a runaway worker behaves differently under the debugger than without it. Detaching restores the worker's callback (V8Debugger::disable removes the debugger's).
Release builds are unaffected (no inspector), and so are debug builds with no DevTools session, or with one that never enables Debugger on the worker target.
Expected
Pausing on OOM while debugging is reasonable and matches Chrome. But after the user resumes (or if the debugger's raised limit is also exhausted), the worker should still be reported and terminated as it is without a debugger. Possible directions:
- Re-register
OnNearHeapLimitafter the worker's inspector session enablesDebugger, so it stays last, and decide explicitly whether to break first. - Or chain: keep the debugger's break, but have the worker's handler run on resume, or once the debug allowance is exhausted.
Repro (sketch)
- Debug build of an app with a worker created with
resourceLimits: { maxOldGenerationSizeMb: 16 }whose script allocates until it runs out of memory. - Without DevTools: the parent gets the heap-limit
error, and the worker ends. - Attach Chrome DevTools to the worker target (which enables
Debugger) and rerun: noerrorreaches the parent. The worker pauses on OOM, or, after resuming, keeps allocating past 16 MB.
Found while reviewing #2070.
- Lenguaje dominante
- C++
- Estrellas
- 565
- Forks
- 147
- Merge medio
- 1 d 2 h
- PR fusionados (30 d)
- 27
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de NativeScript/android
-
improvement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
NativeScript/android#2100 ·
Los mantenedores suelen responder en 1 día
-
ErrorReportActivity draws under the status bar on targetSdk 35 (forced edge-to-edge)Posiblemente ocupada @aleclarson la tomó hace 48 días. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 76/100
NativeScript/android#2053 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 38/100
NativeScript/android#2039 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
NativeScript/android#2024 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 20/100
NativeScript/android#2020 ·
Los mantenedores suelen responder en 1 día
Todos los issues de NativeScript/android
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Nheko-Reborn/nheko#2092 ·
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 78/100
isocpp/CppCoreGuidelines#2345 ·