[PyTorch] Request a migration path for downstream `_GroupedLinear` integrations after the 2.17 signature change
メンテナーはふだん 2 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 静か
調査の方向性
transformer_engine/pytorch/module/grouped_linear.py から始め、f8bda5d0 のコミット前後における _GroupedLinear.forward のシグネチャと linear_fn のディスパッチを調査します。記載されている Megatron-Bridge の pytest ターゲットを実行して len(False) の失敗を再現し、その後、リンクされている ModelOpt と Megatron-Bridge の互換性の例を調べます。対応する移行またはトランジションの動作が文書化され、wrapped linear_fn の呼び出しに対する回帰テストでカバーされていれば完了です。
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
Transformer Engine 2.17 intentionally changed the private PyTorch _GroupedLinear autograd call layout while making GroupedLinear graph-safe.
TE 2.16:
forward(ctx, inp, non_tensor_args, *weights_and_biases)
# non_tensor_args[0] is m_splits
TE 2.17:
forward(ctx, inp, m_splits, non_tensor_args, *weights_and_biases)
# m_splits is now a separate int64 tensor
# non_tensor_args[0] is use_bias
The change was introduced by f8bda5d0. The public GroupedLinear.forward accepts both list and tensor split inputs, while the internal linear_fn dispatch boundary changed positionally.
We understand that _GroupedLinear is private and that downstream users cannot assume its signature will remain stable. In practice, however, there does not appear to be a public functional or interception API for these use cases, so some downstream integrations currently use this boundary to intercept grouped GEMMs or invoke them with externally owned weights. Upgrading TE alone therefore causes deterministic runtime failures in those integrations.
Two downstream examples are affected:
-
NVIDIA ModelOpt intercepts the grouped-linear function to quantize its input and weights. Its compatibility logic finds
non_tensor_argsin the signature and readsnon_tensor_args[0]asm_splits. With TE 2.17, that value isuse_bias, so calibration fails with:File ".../transformer_engine/pytorch/module/grouped_linear.py", line 1788, in forward out, new_workspaces = linear_fn( File ".../modelopt/torch/quantization/plugins/transformer_engine.py", line 178, in te_grouped_quantized_linear_fn num_gemms = len(args[sig_params.index("non_tensor_args") - ctx_offset][0]) TypeError: object of type 'bool' has no len()Tracking issue: NVIDIA/Model-Optimizer#1940
-
Megatron-Bridge directly calls
_GroupedLinear.apply/forwardwith externally owned grouped adapter weights. The TE 2.16 layout passesx, non_tensor_args, weights..., biases.... Under TE 2.17, the same call is shifted: the old tuple is interpreted asm_splits, the first weight is interpreted asnon_tensor_args, and the remaining weights and biases are mispartitioned. The downstream compatibility fix is NVIDIA-NeMo/Megatron-Bridge#4721.
Steps/Code to reproduce bug
The failure is reproduced by changing only the TE pin in Megatron-Bridge PR #4696:
- Passing baseline:
2.16.0+d64bc14datd64bc14dc87eb658ab98839e4b7687595ee53e2d - Failing version:
2.17.0+2e559f06at2e559f062497bef768dfbe9d7e45548fadeca80a - ModelOpt remains pinned at
nvidia-modelopt==0.44.0rc5
Run:
uv run python -m pytest -s -x \
tests/functional_tests/test_groups/quantization/models/qwen/test_qwen3_moe_quantization_workflow.py::TestQwen3MoeQuantizationWorkflow::test_qwen3_moe_quantization_and_generation_with_expert_parallelism
The first calibration forward fails at the len(False) exception shown above. The same failure occurs on both GB200 and H100 runners. Full failing job: Megatron-Bridge GitHub Actions.
The signature transition can also be confirmed directly:
import inspect
from transformer_engine.pytorch.module.grouped_linear import _GroupedLinear
print(inspect.signature(_GroupedLinear.forward))
Requested guidance / compatibility support
We will update the affected downstream integrations to handle the new layout. To make that migration less disruptive, would the TE maintainers consider publishing a TE 2.17.x patch release with a short-lived transition path for both grouped-linear call layouts?
# Legacy layout used through TE 2.16
(ctx, inp, non_tensor_args, *weights_and_biases)
# Graph-safe layout introduced in TE 2.17
(ctx, inp, m_splits, non_tensor_args, *weights_and_biases)
If practical, the compatibility path could cover both grad-enabled _GroupedLinear.apply and direct no-grad _GroupedLinear.forward dispatch, preserve the correct backward arity, and emit a deprecation warning for the legacy form before it is removed in a later feature release. We are not asking for indefinite compatibility for the private API.
Because wrappers such as ModelOpt intercept the linear_fn boundary before _GroupedLinear.forward executes, compatibility may need to be provided at that dispatch/hook boundary rather than only inside the autograd function. A regression test using a wrapped linear_fn would cover this downstream use case.
If dual-layout support at this private boundary is not feasible, guidance on the intended supported approach—or an equivalent stable functional/interception API—would be equally helpful. Public GroupedLinear owns its parameters, so it is not currently a drop-in replacement for callers that need to supply externally owned grouped weights.
Environment overview (please complete the following information)
- Environment location: GitHub Actions, Docker, GCP GPU runners
- Transformer Engine install: Git source pin resolved by
uv - Passing TE:
2.16.0+d64bc14d - Failing TE:
2.17.0+2e559f06 - Downstream packages: Megatron-Bridge PR #4696 and
nvidia-modelopt==0.44.0rc5
Environment details
- OS: Linux container
- Python: 3.12.3
- Transformer Engine: versions and exact commits listed above
- The full container and runner information is recorded in the linked GitHub Actions job.
Device details
- Reproduced on GB200 and H100 CI runners.
Additional context
The old and new contracts are straightforward for downstream code to distinguish when it owns the call: prefer the explicit m_splits parameter when present, otherwise use non_tensor_args[0]. The harder compatibility case is an interceptor that TE calls through the changed positional boundary, which is why a short TE-side transition window would be valuable.
This report concerns only the grouped-linear signature transition. It is independent of other TE 2.17 packaging or import behavior changes.
- 主要言語
- Python
- スター
- 3.6k
- フォーク
- 851
- 平均マージ
- 5日 1時間
- マージ済み PR(30日)
- 52
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
NVIDIA/TransformerEngine のほかの issue
-
[Bug] group_quantize_fp8_blockwise: mbarrier invalidated before other threads finish waiting on itオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
NVIDIA/TransformerEngine#3647 ·
メンテナーはふだん 2 日以内に返信
-
[PyTorch] fp8_cs_quantize fake implementation returns a vector inverse scale instead of a scalar対応中かも @sanjana658 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
NVIDIA/TransformerEngine#3636 · コメント 2 件 ·
メンテナーはふだん 2 日以内に返信
-
[Bug] Backend selection picks FA3 for training with head_dim_qk=192 / v_head_dim=128, but FA3 backward cannot run it対応中かも @yuweih205 が 31 日前に担当しました。 オープンattention
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
NVIDIA/TransformerEngine#3481 · コメント 4 件 ·
メンテナーはふだん 2 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
NVIDIA/TransformerEngine#2189 · コメント 7 件 · リアクション 5 件 ·
メンテナーはふだん 2 日以内に返信
-
[PyTorch] CUDA graph RNG registration floods training logs on automatic-registration builds対応中かも @ksivaman が今日担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 50/100
NVIDIA/TransformerEngine#3645 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 2 日以内に返信
NVIDIA/TransformerEngine の issue をすべて見る
似ている issue
-
bug ready for review
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
odysseus-dev/odysseus#6641 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
happypawspillaro/happypaws#78 ·
メンテナーはふだん 4 日以内に返信
-
pydanty:is-working
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
pydantic/pydantic-ai#10020 ·
メンテナーはふだん 1 日以内に返信
-
Bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
ansible-collections/ibm_zos_core#2650 ·
-
hw: pvc tests: vllm vllm
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
intel/intel-xpu-backend-for-triton#8362 ·
メンテナーはふだん 1 日以内に返信