Metadata rescan reports success when Audible has no record for the ASIN in that region (the book is left unchanged, other regions are never tried)

オープン
#1,124 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
74/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp
領域
api, backend

調査の方向性

Start with LibraryMetadataRescanWorkflow.cs, especially TryMetadataLookupByAsinAsync and EnumerateMetadataRescanRegions; the issue identifies the empty-record check that stops the lookup. Trace how the rescan reports success and applies patches, then check the existing rescan tests. Done means empty Audible records let lookup continue through regions and identifiers, and a rescan with no usable metadata reports failure.

索引モデルが issue の本文から書いたものです。

説明

What happens

POST /api/v1/library/{id}/rescan-metadata answers "Metadata rescanned successfully" and logs Metadata rescan updated audiobook … even when Audible has no record for the book's ASIN in the region it is stored with. Nothing is updated: the book keeps every field it had. The regions where the record does exist are never tried.

Audible answers an ASIN it doesn't sell in a region with an empty record (an ASIN, no title). The rescan takes any non-null answer as a hit (TryMetadataLookupByAsinAsync in LibraryMetadataRescanWorkflow.cs: if (metadataEnvelope == null) continue;, then return true), and ApplyMetadataRescanPatch only writes non-empty fields, so it writes nothing. The loop over EnumerateMetadataRescanRegions stops at that first empty answer.

Reproduce (v1.5.9-canary, API only)

  1. A book whose primary ASIN is a US-only record, e.g. Robinson Crusoe B002V5CW08 (sold in the US, not in France).
  2. Store that ASIN with the region fr (PUT /library/{id}/identifiers), and give the book a title it doesn't have (PUT /library/{id} { "title": "Wrong Title", "subtitle": "Wrong Subtitle" }).
  3. POST /library/{id}/rescan-metadata.

Observed:

rescan : {"message":"Metadata rescanned successfully","audiobookId":1,"source":"Audible","asin":"B002V5CW08","region":"fr"}
after  : Wrong Title | Wrong Subtitle
log    : Metadata rescan updated audiobook 1 (Wrong Title) using Audible ASIN B002V5CW08 region fr

GET /metadata/B002V5CW08?region=fr returns the empty record (no title); ?region=us returns Robinson Crusoe.

Expected

An answer without a title is not a record: the lookup goes on (the next region, then the next identifier), and when nothing has one the rescan fails as "no metadata found" instead of reporting success.

Why it matters

  • Rescan Metadata says it worked on a book whose ASIN region is wrong, and the user has no reason to look further.
  • Repair (#1080 / #1054) saves the picked record's ASIN and region, then rescans. If Audible returns an empty record at that moment, the book shows Repaired with its old metadata. #1054 lists this as a known limit pointing here; it already reports the other case, when the rescan read a different ASIN or region than the one picked.

Found while testing #1054 on a test instance with libraries generated by m4bard/listenarr-testdata.

主要言語
C#
スター
901
フォーク
70
平均マージ
16時間 27分
マージ済み PR(30日)
60

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Listenarrs/Listenarr のほかの issue

Listenarrs/Listenarr の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。