Metadata rescan reports success when Audible has no record for the ASIN in that region (the book is left unchanged, other regions are never tried)

Aperta
#1,124 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
api, backend

Direzione di ricerca

Start with LibraryMetadataRescanWorkflow.cs, especially TryMetadataLookupByAsinAsync and EnumerateMetadataRescanRegions; the issue identifies the empty-record check that stops the lookup. Trace how the rescan reports success and applies patches, then check the existing rescan tests. Done means empty Audible records let lookup continue through regions and identifiers, and a rescan with no usable metadata reports failure.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happens

POST /api/v1/library/{id}/rescan-metadata answers "Metadata rescanned successfully" and logs Metadata rescan updated audiobook … even when Audible has no record for the book's ASIN in the region it is stored with. Nothing is updated: the book keeps every field it had. The regions where the record does exist are never tried.

Audible answers an ASIN it doesn't sell in a region with an empty record (an ASIN, no title). The rescan takes any non-null answer as a hit (TryMetadataLookupByAsinAsync in LibraryMetadataRescanWorkflow.cs: if (metadataEnvelope == null) continue;, then return true), and ApplyMetadataRescanPatch only writes non-empty fields, so it writes nothing. The loop over EnumerateMetadataRescanRegions stops at that first empty answer.

Reproduce (v1.5.9-canary, API only)

  1. A book whose primary ASIN is a US-only record, e.g. Robinson Crusoe B002V5CW08 (sold in the US, not in France).
  2. Store that ASIN with the region fr (PUT /library/{id}/identifiers), and give the book a title it doesn't have (PUT /library/{id} { "title": "Wrong Title", "subtitle": "Wrong Subtitle" }).
  3. POST /library/{id}/rescan-metadata.

Observed:

rescan : {"message":"Metadata rescanned successfully","audiobookId":1,"source":"Audible","asin":"B002V5CW08","region":"fr"}
after  : Wrong Title | Wrong Subtitle
log    : Metadata rescan updated audiobook 1 (Wrong Title) using Audible ASIN B002V5CW08 region fr

GET /metadata/B002V5CW08?region=fr returns the empty record (no title); ?region=us returns Robinson Crusoe.

Expected

An answer without a title is not a record: the lookup goes on (the next region, then the next identifier), and when nothing has one the rescan fails as "no metadata found" instead of reporting success.

Why it matters

  • Rescan Metadata says it worked on a book whose ASIN region is wrong, and the user has no reason to look further.
  • Repair (#1080 / #1054) saves the picked record's ASIN and region, then rescans. If Audible returns an empty record at that moment, the book shows Repaired with its old metadata. #1054 lists this as a known limit pointing here; it already reports the other case, when the rescan read a different ASIN or region than the one picked.

Found while testing #1054 on a test instance with libraries generated by m4bard/listenarr-testdata.

Lingua principale
C#
Stelle
901
Fork
70
Merge medio
16h 27m
PR unite (30g)
60

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Listenarrs/Listenarr

Tutte le issue di Listenarrs/Listenarr

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.