Metadata rescan reports success when Audible has no record for the ASIN in that region (the book is left unchanged, other regions are never tried)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 74/100
Direzione di ricerca
Start with LibraryMetadataRescanWorkflow.cs, especially TryMetadataLookupByAsinAsync and EnumerateMetadataRescanRegions; the issue identifies the empty-record check that stops the lookup. Trace how the rescan reports success and applies patches, then check the existing rescan tests. Done means empty Audible records let lookup continue through regions and identifiers, and a rescan with no usable metadata reports failure.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
POST /api/v1/library/{id}/rescan-metadata answers "Metadata rescanned successfully" and logs Metadata rescan updated audiobook … even when Audible has no record for the book's ASIN in the region it is stored with. Nothing is updated: the book keeps every field it had. The regions where the record does exist are never tried.
Audible answers an ASIN it doesn't sell in a region with an empty record (an ASIN, no title). The rescan takes any non-null answer as a hit (TryMetadataLookupByAsinAsync in LibraryMetadataRescanWorkflow.cs: if (metadataEnvelope == null) continue;, then return true), and ApplyMetadataRescanPatch only writes non-empty fields, so it writes nothing. The loop over EnumerateMetadataRescanRegions stops at that first empty answer.
Reproduce (v1.5.9-canary, API only)
- A book whose primary ASIN is a US-only record, e.g. Robinson Crusoe
B002V5CW08(sold in the US, not in France). - Store that ASIN with the region
fr(PUT /library/{id}/identifiers), and give the book a title it doesn't have (PUT /library/{id}{ "title": "Wrong Title", "subtitle": "Wrong Subtitle" }). POST /library/{id}/rescan-metadata.
Observed:
rescan : {"message":"Metadata rescanned successfully","audiobookId":1,"source":"Audible","asin":"B002V5CW08","region":"fr"}
after : Wrong Title | Wrong Subtitle
log : Metadata rescan updated audiobook 1 (Wrong Title) using Audible ASIN B002V5CW08 region fr
GET /metadata/B002V5CW08?region=fr returns the empty record (no title); ?region=us returns Robinson Crusoe.
Expected
An answer without a title is not a record: the lookup goes on (the next region, then the next identifier), and when nothing has one the rescan fails as "no metadata found" instead of reporting success.
Why it matters
- Rescan Metadata says it worked on a book whose ASIN region is wrong, and the user has no reason to look further.
- Repair (#1080 / #1054) saves the picked record's ASIN and region, then rescans. If Audible returns an empty record at that moment, the book shows Repaired with its old metadata. #1054 lists this as a known limit pointing here; it already reports the other case, when the rescan read a different ASIN or region than the one picked.
Found while testing #1054 on a test instance with libraries generated by m4bard/listenarr-testdata.
- Lingua principale
- C#
- Stelle
- 901
- Fork
- 70
- Merge medio
- 16h 27m
- PR unite (30g)
- 60
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Listenarrs/Listenarr
-
Search button on a book does not retry without the author when the full query finds nothingForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Listenarrs/Listenarr#1173 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
Listenarrs/Listenarr#1133 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
Listenarrs/Listenarr#1128 ·
I maintainer di solito rispondono entro 1 giorno
-
Add New's search splits a title that contains "Series:", "Author:"… as if they were search keywordsAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
Listenarrs/Listenarr#1127 ·
I maintainer di solito rispondono entro 1 giorno
-
p3
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
Listenarrs/Listenarr#971 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Listenarrs/Listenarr
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
conductor-oss/csharp-sdk#183 ·
-
CreateNewLangProj throws when the default analysis writing system's ICU locale differs from its tagAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
kind/bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
unoplatform/uno#26555 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
CactuseSecurity/firewall-orchestrator#5739 ·
I maintainer di solito rispondono entro 1 giorno
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
I maintainer di solito rispondono entro 1 giorno