Fail the build on high-severity dependency advisories

オープン
#338 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 4 日以内に返信

@IanoNjuguna がすでに取り組んでいます。

2026年11月22日 から。

  • #405 @IanoNjuguna による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
58/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
github-actions, json, typescript

調査の方向性

Start by reading website/package.json, .github/workflows/pr-build-website.yml, the deploy workflow, and TRIAGE.md. Decide and document how unfixable high-severity advisories such as braces and node-forge are handled, then add and verify the audit step after npm ci in both build paths. Done means high and critical findings fail where intended, while the documented exception or scope policy prevents an indiscriminate gate from blocking every build.

索引モデルが issue の本文から書いたものです。

説明

enhancement Medium Priority Security

Problem statement

website/package.json defines audit:ci (npm audit --audit-level=high), and no workflow runs it. Grepping .github/workflows/ for npm audit or audit:ci returns nothing.

So a dependency with a known high-severity advisory can be merged today, and the first anyone hears about it is a Dependabot alert after the fact. The current open alerts (node-forge, braces) are exactly the class of problem a gate would have surfaced at the point of change rather than in the Security tab later.

Proposed solution

Add an advisory check to the existing PR build gate (pr-build-website.yml) and to the deploy workflow, so the same step runs on the way in and on the way to production:

  • Run npm run audit:ci (or npm audit --audit-level=high) after npm ci.
  • Fail the job on high or critical findings.
  • Do not fail on moderate or low, otherwise the gate becomes noise and gets bypassed.

Open question worth settling in the PR: whether to gate on findings with no available fix. braces (CVE-2026-93687) and node-forge (CVE-2026-85393) currently have no patched release, so a strict gate would block every build. The gate is only useful if the unfixable set is explicitly allow-listed, or if npm audit is run with --omit=dev so build-tool findings do not gate releases.

Scope and impact

Touches one workflow file. Risk is a gate that reddens builds for advisories nobody can fix; the allow-list decision above needs to be made first, and should be written into TRIAGE.md so it does not drift.

Acceptance criteria:

  • High and critical advisories fail the PR build
  • The unfixable set is documented rather than silently tolerated
  • TRIAGE.md describes the gate alongside Dependabot and CodeQL

Absorbed from #339

#339 was closed when its alerts resolved themselves (the braces advisory was withdrawn and website/yarn.lock was deleted). Its third acceptance box moved here, because this issue already owns the TRIAGE.md write-up:

  • TRIAGE.md also states the dismissal bar: who may dismiss a finding, which reasons are acceptable, and that a dismissal needs a comment naming the condition that reopens it.
主要言語
TypeScript
スター
13
フォーク
24
平均マージ
2日 3時間
マージ済み PR(30日)
16

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

IntersectMBO/developer-experience のほかの issue

IntersectMBO/developer-experience の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。