Fail the build on high-severity dependency advisories

Aperta
#338 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

@IanoNjuguna ci sta già lavorando.

Dal 22/11/2026.

  • #405 di @IanoNjuguna — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github-actions, json, typescript

Direzione di ricerca

Start by reading website/package.json, .github/workflows/pr-build-website.yml, the deploy workflow, and TRIAGE.md. Decide and document how unfixable high-severity advisories such as braces and node-forge are handled, then add and verify the audit step after npm ci in both build paths. Done means high and critical findings fail where intended, while the documented exception or scope policy prevents an indiscriminate gate from blocking every build.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement Medium Priority Security

Problem statement

website/package.json defines audit:ci (npm audit --audit-level=high), and no workflow runs it. Grepping .github/workflows/ for npm audit or audit:ci returns nothing.

So a dependency with a known high-severity advisory can be merged today, and the first anyone hears about it is a Dependabot alert after the fact. The current open alerts (node-forge, braces) are exactly the class of problem a gate would have surfaced at the point of change rather than in the Security tab later.

Proposed solution

Add an advisory check to the existing PR build gate (pr-build-website.yml) and to the deploy workflow, so the same step runs on the way in and on the way to production:

  • Run npm run audit:ci (or npm audit --audit-level=high) after npm ci.
  • Fail the job on high or critical findings.
  • Do not fail on moderate or low, otherwise the gate becomes noise and gets bypassed.

Open question worth settling in the PR: whether to gate on findings with no available fix. braces (CVE-2026-93687) and node-forge (CVE-2026-85393) currently have no patched release, so a strict gate would block every build. The gate is only useful if the unfixable set is explicitly allow-listed, or if npm audit is run with --omit=dev so build-tool findings do not gate releases.

Scope and impact

Touches one workflow file. Risk is a gate that reddens builds for advisories nobody can fix; the allow-list decision above needs to be made first, and should be written into TRIAGE.md so it does not drift.

Acceptance criteria:

  • High and critical advisories fail the PR build
  • The unfixable set is documented rather than silently tolerated
  • TRIAGE.md describes the gate alongside Dependabot and CodeQL

Absorbed from #339

#339 was closed when its alerts resolved themselves (the braces advisory was withdrawn and website/yarn.lock was deleted). Its third acceptance box moved here, because this issue already owns the TRIAGE.md write-up:

  • TRIAGE.md also states the dismissal bar: who may dismiss a finding, which reasons are acceptable, and that a dismissal needs a comment naming the condition that reopens it.
Lingua principale
TypeScript
Stelle
13
Fork
24
Merge medio
2g 3h
PR unite (30g)
16

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di IntersectMBO/developer-experience

Tutte le issue di IntersectMBO/developer-experience

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.