Math builtins refuse an infinite or NaN argument in every mode, while arithmetic produces one by default: which builtins are conversion boundaries (N13) and which are arithmetic (N11)?

オープン
#2,444 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c
領域
compilers

調査の方向性

Read decision N13 in #1758 and inspect eigs_number_arg plus its 28 call sites in src/eigenscript.c to classify each builtin as a conversion boundary or arithmetic. Check docs/BUILTINS.md and tools/strict_differential.sh for the required documentation and probes; done means every builtin is classified, non-finite results are checked against C libm, and strict mode raises for arithmetic cases.

索引モデルが issue の本文から書いたものです。

説明

area:stdlib kind:decision

What. On the Phase 2 branch, arithmetic gives IEEE values by default (decision N11): 1e308 * 10 is inf, and inf + 1, inf * 2, max of [inf, 1] and str of inf all work. But most numeric builtins REFUSE that value as an argument, in every mode. Run on fix-2439 at 5e107ddb, no EIGS_ variable set, with x is 1e308 * 10:

expression result IEEE / C
sqrt of x sqrt/exp/log: expected a finite number inf
exp of x sqrt/exp/log: expected a finite number inf
atan of x atan: expected a finite number π/2
abs of x abs: expected a finite number inf
negative of x negative: expected a finite number -inf
x ^ 2 '^': number inf has no integer representation inf
floor of x floor: expected a finite number (no integer: a refusal is one defensible answer)

The refusal is in the shared argument reader (eigs_number_arg, src/eigenscript.c), which 28 call sites use. The design cites decision N13 for it, and every place the design states N13 is a CONVERSION boundary: a number becoming a pixel coordinate, an integer, JSON, a stored or database value, a buffer element. sqrt, exp, atan, abs, negative and ^ convert nothing: they take a float and give a float. docs/BUILTINS.md says nothing of the refusal for abs.

Why it matters. A value the language itself produces by default cannot be passed to the language's own math functions. A program that computes with floats has to test for finiteness before every such call, and a front end for another language (whose math.sqrt(math.huge) is inf) has to wrap each one. Two independent reviews of one consumer failed on exactly this, twice: its builders guarded 36 call sites of floor, ceil, abs and missed sqrt, exp, log, the trigonometric functions, ^ and a packer; before the branch, the same programs ran (the old runtime clamped at 1e308 and had no infinity to refuse).

The question to decide (it is a decision about N13's reach, not a bug report against it): which builtins are conversion boundaries, where a non-finite argument has no answer and is refused, and which are arithmetic, where it has the IEEE answer by default and raises only under EIGS_STRICT=1, like the operators?

Done when

  • Every builtin that reads a number through eigs_number_arg (28 call sites today) is classified in the design, by name: conversion (refuses a non-finite argument in every mode) or arithmetic (IEEE result by default; the arithmetic trap under EIGS_STRICT=1).
  • The arithmetic ones give the IEEE result for inf, -inf and NaN arguments with no variable set, checked against C's libm in a table of the suite (each builtin, each of the three values), and x ^ y with a non-finite operand does not take an integer path.
  • docs/BUILTINS.md says, for each numeric builtin, what a non-finite argument gives.
  • tools/strict_differential.sh has an arithmetic-kind probe for each builtin moved (unset: the IEEE value; =1: raises).

Refs #1758 (N11, N13), #2439.

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。