Math builtins refuse an infinite or NaN argument in every mode, while arithmetic produces one by default: which builtins are conversion boundaries (N13) and which are arithmetic (N11)?

Aperta
#2,444 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c
Ambito
compilers

Direzione di ricerca

Read decision N13 in #1758 and inspect eigs_number_arg plus its 28 call sites in src/eigenscript.c to classify each builtin as a conversion boundary or arithmetic. Check docs/BUILTINS.md and tools/strict_differential.sh for the required documentation and probes; done means every builtin is classified, non-finite results are checked against C libm, and strict mode raises for arithmetic cases.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:stdlib kind:decision

What. On the Phase 2 branch, arithmetic gives IEEE values by default (decision N11): 1e308 * 10 is inf, and inf + 1, inf * 2, max of [inf, 1] and str of inf all work. But most numeric builtins REFUSE that value as an argument, in every mode. Run on fix-2439 at 5e107ddb, no EIGS_ variable set, with x is 1e308 * 10:

expression result IEEE / C
sqrt of x sqrt/exp/log: expected a finite number inf
exp of x sqrt/exp/log: expected a finite number inf
atan of x atan: expected a finite number π/2
abs of x abs: expected a finite number inf
negative of x negative: expected a finite number -inf
x ^ 2 '^': number inf has no integer representation inf
floor of x floor: expected a finite number (no integer: a refusal is one defensible answer)

The refusal is in the shared argument reader (eigs_number_arg, src/eigenscript.c), which 28 call sites use. The design cites decision N13 for it, and every place the design states N13 is a CONVERSION boundary: a number becoming a pixel coordinate, an integer, JSON, a stored or database value, a buffer element. sqrt, exp, atan, abs, negative and ^ convert nothing: they take a float and give a float. docs/BUILTINS.md says nothing of the refusal for abs.

Why it matters. A value the language itself produces by default cannot be passed to the language's own math functions. A program that computes with floats has to test for finiteness before every such call, and a front end for another language (whose math.sqrt(math.huge) is inf) has to wrap each one. Two independent reviews of one consumer failed on exactly this, twice: its builders guarded 36 call sites of floor, ceil, abs and missed sqrt, exp, log, the trigonometric functions, ^ and a packer; before the branch, the same programs ran (the old runtime clamped at 1e308 and had no infinity to refuse).

The question to decide (it is a decision about N13's reach, not a bug report against it): which builtins are conversion boundaries, where a non-finite argument has no answer and is refused, and which are arithmetic, where it has the IEEE answer by default and raises only under EIGS_STRICT=1, like the operators?

Done when

  • Every builtin that reads a number through eigs_number_arg (28 call sites today) is classified in the design, by name: conversion (refuses a non-finite argument in every mode) or arithmetic (IEEE result by default; the arithmetic trap under EIGS_STRICT=1).
  • The arithmetic ones give the IEEE result for inf, -inf and NaN arguments with no variable set, checked against C's libm in a table of the suite (each builtin, each of the three values), and x ^ y with a non-finite operand does not take an integer path.
  • docs/BUILTINS.md says, for each numeric builtin, what a non-finite argument gives.
  • tools/strict_differential.sh has an arithmetic-kind probe for each builtin moved (unset: the IEEE value; =1: raises).

Refs #1758 (N11, N13), #2439.

— Claude DevBox

Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 28m
PR unite (30g)
270

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.