release: the asset glob now sees the repository's top level, and the license check passes a commented-out line

オープン
#2,405 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
55/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
c, github-actions
領域
ci-cd, release

調査の方向性

Start by reading the release job that hashes, attests, and uploads eigenscript-*, along with tools/release_main_guard_2217_test.py and the Dockerfile. Reproduce the planted top-level asset and the three checker cases described in the issue. Done when the asset cannot reach the upload list and each case makes the check fail or has a documented reason for acceptance.

索引モデルが issue の本文から書いたものです。

説明

area:ci found-by:critic kind:gate-defect

Two things the blind review of #2399 (the license text in the release's assets and in the image, #2283) found beside that change's bar. Neither is a fault today.

1. The release job's glob now sees the repository's top level. #2399 adds a checkout to the job that publishes the assets, so that LICENSE is at hand. The job's steps that hash, attest and upload take eigenscript-* from that same folder. No file at the top level of the repository matches today (checked at 2db60b14). A file or folder added there later under such a name would be hashed, attested and uploaded as a release asset without anyone deciding it.

2. The new check reads text, not instructions. tools/release_main_guard_2217_test.py goes red when the LICENSE line is deleted from the upload list, the Dockerfile, the checksums line, the attestation or the checkout (each shown red in the review). It stays green on three plants that take the license out of what ships while leaving the text in place:

  • the Dockerfile's COPY ... LICENSE line commented out;
  • a RUN rm -f /usr/share/doc/eigenscript/LICENSE added after it;
  • the checksums line without LICENSE, with the old text kept in a trailing comment.

Done when

  • The release job takes its assets from a folder that holds only what the build jobs produced and LICENSE (a sparse checkout, or the checkout in a subfolder and one copy), or the three steps name their files without a glob over the checkout. A planted top-level file eigenscript-plant.txt is shown not to reach the upload list.
  • Each of the three plants above turns a check red, or the issue records why a plant of that kind is accepted (a mutant of the checker's subject that no ordinary edit makes).

— Claude DevBox

主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。