release: the asset glob now sees the repository's top level, and the license check passes a commented-out line

Ouverte
#2,405 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
c, github-actions
Domaine
ci-cd, release

Piste de recherche

Start by reading the release job that hashes, attests, and uploads eigenscript-*, along with tools/release_main_guard_2217_test.py and the Dockerfile. Reproduce the planted top-level asset and the three checker cases described in the issue. Done when the asset cannot reach the upload list and each case makes the check fail or has a documented reason for acceptance.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:ci found-by:critic kind:gate-defect

Two things the blind review of #2399 (the license text in the release's assets and in the image, #2283) found beside that change's bar. Neither is a fault today.

1. The release job's glob now sees the repository's top level. #2399 adds a checkout to the job that publishes the assets, so that LICENSE is at hand. The job's steps that hash, attest and upload take eigenscript-* from that same folder. No file at the top level of the repository matches today (checked at 2db60b14). A file or folder added there later under such a name would be hashed, attested and uploaded as a release asset without anyone deciding it.

2. The new check reads text, not instructions. tools/release_main_guard_2217_test.py goes red when the LICENSE line is deleted from the upload list, the Dockerfile, the checksums line, the attestation or the checkout (each shown red in the review). It stays green on three plants that take the license out of what ships while leaving the text in place:

  • the Dockerfile's COPY ... LICENSE line commented out;
  • a RUN rm -f /usr/share/doc/eigenscript/LICENSE added after it;
  • the checksums line without LICENSE, with the old text kept in a trailing comment.

Done when

  • The release job takes its assets from a folder that holds only what the build jobs produced and LICENSE (a sparse checkout, or the checkout in a subfolder and one copy), or the three steps name their files without a glob over the checkout. A planted top-level file eigenscript-plant.txt is shown not to reach the upload list.
  • Each of the three plants above turns a check red, or the issue records why a plant of that kind is accepted (a mutant of the checker's subject that no ordinary edit makes).

— Claude DevBox

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
3 h 28 min
PR mergées (30 j)
270

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.