HTTP server: `EIGS_HTTP_MAX_BODY=1e6` gives a body limit of 1 byte (six limit variables keep only a value's leading digits)

オープン
#2,389 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
53/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
c
領域
backend

調査の方向性

Start with the limit parsing in src/ext_http.c and the EIGS_HTTP_MAX_HEAD rule added in #2370; read docs/BUILTINS.md for the documented variable rules. Add coverage for all six variables using the listed values and a planted fault that reproduces the current parsing behavior. Done means the parsing rule and invalid-value behavior are decided, tests cover every variable, and docs/BUILTINS.md documents each rule.

索引モデルが issue の本文から書いたものです。

説明

area:http kind:silent-wrong

Found while building #2370, whose text leaves it out by name: "EIGS_HTTP_MAX_BODY is read more loosely today, and that is not changed here".

What happens today

Run on the branch of #2370 at 5fc6d926 (make http). The function that reads the variable is the same there as at 5b93b236, the head of phase2-numbers. A server with one POST route was started with the variable set, and bodies of 1, 2, 5, 6, 16, 17, 100,000 and 17,000,000 bytes were sent, each with its Content-Length:

EIGS_HTTP_MAX_BODY the limit the server then has
unset, 0, -5, abc, 0x10 the default, 16 MiB
1e6 1 byte: a body of 2 bytes is answered 413
16MiB 16 bytes
5x 5 bytes
6 (a space first), +6, 6.9 6 bytes
99999999999999999999 none that these sizes reach: the body of 17,000,000 bytes is served

http_max_body in src/ext_http.c reads the value with strtol(env, &end, 10) and takes the number when at least one digit was read and it is over zero. What follows the digits is not looked at, and a value too large for a long becomes the largest long.

Five more variables of the server are read by the same lines: EIGS_HTTP_MAX_BODY_TOTAL, EIGS_HTTP_MAX_CONN_PER_IP, EIGS_HTTP_HEADER_TIMEOUT, EIGS_HTTP_HEADER_MIN_RATE and EIGS_HTTP_SHARED_MAX_BYTES. Those five were read in the source and not run.

EIGS_HTTP_MAX_HEAD, which #2370 adds, has a rule: one to nine decimal digits and not zero, and any other value leaves the default.

Why it matters

A limit written as 1e6 or 16MiB gives a server that refuses every request with a body of more than a few bytes, and nothing says why. A value that is too large takes the limit away.

Done when

  • Each of the server's limit variables is read by one stated rule (the rule of EIGS_HTTP_MAX_HEAD, or another written in docs/BUILTINS.md), and a value that breaks the rule never becomes a number other than the one written.
  • What a value that breaks the rule does is decided in this issue before it is built, one way for all of them: it leaves the default, as EIGS_HTTP_MAX_HEAD does, or http_serve refuses to start and names the variable.
  • A row for each variable with the values of the table above, and a planted fault (today's reading) that turns each row red.
  • docs/BUILTINS.md gives the rule beside each variable.
主要言語
C
スター
3
フォーク
7
平均マージ
3時間 28分
マージ済み PR(30日)
270

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

InauguralSystems/EigenScript のほかの issue

InauguralSystems/EigenScript の issue をすべて見る

似ている issue

C の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。