HTTP server: `EIGS_HTTP_MAX_BODY=1e6` gives a body limit of 1 byte (six limit variables keep only a value's leading digits)

Abierto
#2,389 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
c
Área
backend

Línea de trabajo

Start with the limit parsing in src/ext_http.c and the EIGS_HTTP_MAX_HEAD rule added in #2370; read docs/BUILTINS.md for the documented variable rules. Add coverage for all six variables using the listed values and a planted fault that reproduces the current parsing behavior. Done means the parsing rule and invalid-value behavior are decided, tests cover every variable, and docs/BUILTINS.md documents each rule.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:http kind:silent-wrong

Found while building #2370, whose text leaves it out by name: "EIGS_HTTP_MAX_BODY is read more loosely today, and that is not changed here".

What happens today

Run on the branch of #2370 at 5fc6d926 (make http). The function that reads the variable is the same there as at 5b93b236, the head of phase2-numbers. A server with one POST route was started with the variable set, and bodies of 1, 2, 5, 6, 16, 17, 100,000 and 17,000,000 bytes were sent, each with its Content-Length:

EIGS_HTTP_MAX_BODY the limit the server then has
unset, 0, -5, abc, 0x10 the default, 16 MiB
1e6 1 byte: a body of 2 bytes is answered 413
16MiB 16 bytes
5x 5 bytes
6 (a space first), +6, 6.9 6 bytes
99999999999999999999 none that these sizes reach: the body of 17,000,000 bytes is served

http_max_body in src/ext_http.c reads the value with strtol(env, &end, 10) and takes the number when at least one digit was read and it is over zero. What follows the digits is not looked at, and a value too large for a long becomes the largest long.

Five more variables of the server are read by the same lines: EIGS_HTTP_MAX_BODY_TOTAL, EIGS_HTTP_MAX_CONN_PER_IP, EIGS_HTTP_HEADER_TIMEOUT, EIGS_HTTP_HEADER_MIN_RATE and EIGS_HTTP_SHARED_MAX_BYTES. Those five were read in the source and not run.

EIGS_HTTP_MAX_HEAD, which #2370 adds, has a rule: one to nine decimal digits and not zero, and any other value leaves the default.

Why it matters

A limit written as 1e6 or 16MiB gives a server that refuses every request with a body of more than a few bytes, and nothing says why. A value that is too large takes the limit away.

Done when

  • Each of the server's limit variables is read by one stated rule (the rule of EIGS_HTTP_MAX_HEAD, or another written in docs/BUILTINS.md), and a value that breaks the rule never becomes a number other than the one written.
  • What a value that breaks the rule does is decided in this issue before it is built, one way for all of them: it leaves the default, as EIGS_HTTP_MAX_HEAD does, or http_serve refuses to start and names the variable.
  • A row for each variable with the values of the table above, and a planted fault (today's reading) that turns each row red.
  • docs/BUILTINS.md gives the rule beside each variable.
Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.