Bootstrap fit: residual cases of the plugin's fixed per-entry framing estimate

オープン
#53 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
javascript
領域
api, tooling

調査の方向性

Start from the server's GET /Memory/bootstrap response, where entryOverhead and sectionItemOverhead are added by PR #50, and from the plugin's fixed per-entry framing estimate (~308 chars) and its ordered-prefix render. Reproduce case 1 with a pin whose title + content is about 3,420–3,530 chars at the default 4,000 budget, then case 2 with a lastEditor or longer scopes. The fix needs a decision on whether the server counts provenance strings, so settle that with maintainers first. Done means every entry that fits the budget is injected or the omission is explained.

索引モデルが issue の本文から書いたものです。

説明

Deferred from Claude Code plugin: inject all of bootstrap within budget, render section entries and summaryTree topics review.

That PR adds entryOverhead and sectionItemOverhead to GET /Memory/bootstrap. The Claude Code plugin sends a fixed per-entry framing estimate, computed from its own header format for an entry with:

  • a 64-char id
  • a 32-char author and no lastEditor
  • 64 chars of scopes
  • the longest built-in section

That estimate is ~308 chars per memory; typical entries frame in ~180–220. Because it is one constant per request, three cases remain:

  1. Boundary window. An entry whose title + content comes within about the estimate's slack (~100 chars) of the request budget is not packed, even though it would render within the injection budget. At the default 4,000 budget this is a pin with title + content of about 3,420–3,530 chars. The authoritative offline-cache save then leaves it out too.
  2. Metadata beyond the estimate. The server packs these entries, but the plugin's ordered-prefix render stops at the first one that does not fit, and the rest of the response is not injected. They stay in watchedIds. Examples:
    • a lastEditor
    • principal ids longer than 32 chars
    • more than ~64 chars of scopes (up to 16 × 128 are legal)
    • escaped characters, or bodies that sanitizing lengthens
  3. Offline cache render. The stale-cache path renders with skip-ahead rather than the ordered prefix. That is deliberate (the cache was packed for an earlier request), but it differs from the online path.

Possible fix for 1 and 2: the server also counts each entry's provenance strings (id, author, lastEditor, scopes, section), so the client's overhead covers only its fixed framing. That puts one client's header field list in the server contract, which is why the PR shipped the constant.

Review-Deferral: 3e7b1f54450ae2b7 severity=nit category=correctness
Review-Deferral: d4b1192533479e66 severity=nit category=correctness

主要言語
JavaScript
スター
0
フォーク
0
平均マージ
20時間 29分
マージ済み PR(30日)
28

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

HarperFast/agent-memory のほかの issue

HarperFast/agent-memory の issue をすべて見る

似ている issue

JavaScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。