The first bot can't be deleted even after another bot is the Chief of Staff

オープン
#75 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
43/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
backend

調査の方向性

Read server/store.ts around deleteBot and server/default-bot.ts around defaultBotPatchRefusal and ensureDefaultBot; trace how the default bot marker and its ledger are updated when a bot is deleted. Check the bot deletion and patch route tests, then add coverage for deleting the former default bot after another bot becomes Chief of Staff. Done means the former default bot can be removed while the current Chief remains protected and the helper ledger behaves as intended.

索引モデルが issue の本文から書いたものです。

説明

What happened

The bot this place made first — the starter, marked as the helper (defaultBot) — can be hidden from the sidebar, but it can never be deleted, and that does not change once another bot is the Chief of Staff. Delete answers:

dusk bot can't be deleted or archived. To take it off the sidebar, choose Hide in its menu, …

Verified on an isolated fixture (nothing of mine touched):

Dusk is the first bot, marked defaultBot
PATCH Dusk {sidebarHidden:true}   200     <- Hide from sidebar works
PATCH Dusk {hidden:true}          400     same "can't be deleted or archived" sentence
DELETE Dusk                       409     same sentence
make Bravo chief                  200
(make Charlie chief)              200     Dusk's crown is cleared, as it should be
DELETE Dusk                       409     still refused, chief or not

So the crown is not what blocks it. The refusal keys on the marker, not on the role:

  • server/store.ts:1478 — deleteBot throws for any bot.defaultBot.
  • server/default-bot.ts:29 (defaultBotPatchRefusal, used by server/routes/bot-patch.ts) — hidden: true is refused for the same bots.
  • server/default-bot.ts:145 (ensureDefaultBot) — a place that has had its helper never gets another one made (if (Object.hasOwn(ledger(...), person)) return null), so the marker effectively pins that row for the life of the place.
  • Nothing in the UI can move the marker: takeArrivingDefaultBot moves it only when a move brings another place's helper in.

The Chief's Hide being refused is intended (it is a different guard, bot-patch.ts:447, and I am not asking for it). This is only about the first/former bot.

Why it reads as a bug from here: the first bot is the throwaway starter. People rename it, use it for a while, then set up real bots and move the Chief of Staff; what is left is an ordinary-looking row that refuses Delete and offers only Hide — which keeps the bot, its conversations, its memory, its workspace folder and any routine it owns alive, with no way to remove them.

Steps to reproduce
  1. New install: the starter bot is the only bot and the Chief of Staff.
  2. Make another bot the Chief of Staff (the starter's crown is cleared).
  3. Right-click the starter → Delete: refused with the notice above, whatever the crown says.
  4. Right-click it → Hide from sidebar: works, and it is the only way out the app offers.
Version

0.2.17

Platform

macOS

Engine

No response

Logs or screenshots
Measured: DELETE defaultBot 409, PATCH {hidden:true} 400, PATCH {sidebarHidden:true} 200, before and
after another bot is the Chief.

What would settle it, in order of what the code already supports:
1. Let the marked bot be deleted once the place has another bot: clear the marker with it, and let the
   ledger record that this place's helper is gone (ensureDefaultBot already knows how to adopt an
   existing bot instead of creating one, should the person want a helper again).
2. Or offer "Make … my helper" so the marker can move to another bot, after which the old first bot is
   an ordinary bot and deletes normally.
3. Whatever the rule, the notice should name the helper as the reason — and stop pointing at a settings
   switch that is not in Settings → General (filed separately as #74).
主要言語
TypeScript
スター
277
フォーク
27
平均マージ
2時間 47分
マージ済み PR(30日)
1

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DuskBotAI/duskbot のほかの issue

DuskBotAI/duskbot の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。