The first bot can't be deleted even after another bot is the Chief of Staff

Aperta
#75 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
43/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend

Direzione di ricerca

Read server/store.ts around deleteBot and server/default-bot.ts around defaultBotPatchRefusal and ensureDefaultBot; trace how the default bot marker and its ledger are updated when a bot is deleted. Check the bot deletion and patch route tests, then add coverage for deleting the former default bot after another bot becomes Chief of Staff. Done means the former default bot can be removed while the current Chief remains protected and the helper ledger behaves as intended.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happened

The bot this place made first — the starter, marked as the helper (defaultBot) — can be hidden from the sidebar, but it can never be deleted, and that does not change once another bot is the Chief of Staff. Delete answers:

dusk bot can't be deleted or archived. To take it off the sidebar, choose Hide in its menu, …

Verified on an isolated fixture (nothing of mine touched):

Dusk is the first bot, marked defaultBot
PATCH Dusk {sidebarHidden:true}   200     <- Hide from sidebar works
PATCH Dusk {hidden:true}          400     same "can't be deleted or archived" sentence
DELETE Dusk                       409     same sentence
make Bravo chief                  200
(make Charlie chief)              200     Dusk's crown is cleared, as it should be
DELETE Dusk                       409     still refused, chief or not

So the crown is not what blocks it. The refusal keys on the marker, not on the role:

  • server/store.ts:1478 — deleteBot throws for any bot.defaultBot.
  • server/default-bot.ts:29 (defaultBotPatchRefusal, used by server/routes/bot-patch.ts) — hidden: true is refused for the same bots.
  • server/default-bot.ts:145 (ensureDefaultBot) — a place that has had its helper never gets another one made (if (Object.hasOwn(ledger(...), person)) return null), so the marker effectively pins that row for the life of the place.
  • Nothing in the UI can move the marker: takeArrivingDefaultBot moves it only when a move brings another place's helper in.

The Chief's Hide being refused is intended (it is a different guard, bot-patch.ts:447, and I am not asking for it). This is only about the first/former bot.

Why it reads as a bug from here: the first bot is the throwaway starter. People rename it, use it for a while, then set up real bots and move the Chief of Staff; what is left is an ordinary-looking row that refuses Delete and offers only Hide — which keeps the bot, its conversations, its memory, its workspace folder and any routine it owns alive, with no way to remove them.

Steps to reproduce
  1. New install: the starter bot is the only bot and the Chief of Staff.
  2. Make another bot the Chief of Staff (the starter's crown is cleared).
  3. Right-click the starter → Delete: refused with the notice above, whatever the crown says.
  4. Right-click it → Hide from sidebar: works, and it is the only way out the app offers.
Version

0.2.17

Platform

macOS

Engine

No response

Logs or screenshots
Measured: DELETE defaultBot 409, PATCH {hidden:true} 400, PATCH {sidebarHidden:true} 200, before and
after another bot is the Chief.

What would settle it, in order of what the code already supports:
1. Let the marked bot be deleted once the place has another bot: clear the marker with it, and let the
   ledger record that this place's helper is gone (ensureDefaultBot already knows how to adopt an
   existing bot instead of creating one, should the person want a helper again).
2. Or offer "Make … my helper" so the marker can move to another bot, after which the old first bot is
   an ordinary bot and deletes normally.
3. Whatever the rule, the notice should name the helper as the reason — and stop pointing at a settings
   switch that is not in Settings → General (filed separately as #74).
Lingua principale
TypeScript
Stelle
277
Fork
27
Merge medio
2h 47m
PR unite (30g)
1

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DuskBotAI/duskbot

Tutte le issue di DuskBotAI/duskbot

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.