Vault doesn't follow between this computer and a remote server

オープン
#72 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript
領域
backend

調査の方向性

Read server/saved-secrets.ts, server/settings-sync.ts, server/connector-sync.ts, and server/vault-move.ts to understand the per-place Vault and existing sync and move behavior; check server/cloud-send-vault.e2e.test.ts and electron/vps-cloud-move.mjs for related flows. The issue leaves a product decision open between syncing Vault items and keeping them per place with labeling and copy, so get that decision before estimating implementation. Done means the chosen behavior is implemented and the two-place reproduction no longer leaves users guessing or without a way to access their items.

索引モデルが issue の本文から書いたものです。

説明

What happened

The Vault is per place. Settings, API keys and connector sign-ins follow you across your computers and servers, but saved logins, saved secrets and 1Password do not: an item saved while the window is on a remote server is not on this computer, and one saved here is not on the server. Settings → Vault lists whichever place the window is on without saying so, so the other place's items read as lost.

Nothing keeps the two sides level. The only path a Vault item has out of a machine is a one-time move, and only in the direction of the move:

  • server/saved-secrets.ts — the saved secrets file is "not backed up, exported or synced ... only a move to the person's own Cloud carries each secret".
  • server/settings-sync.ts (WHOLE, FIELDS, SYNCED_SECRETS) and server/connector-sync.ts carry settings, API keys and connector sign-ins; no logins, no saved secrets, no 1Password token or per-vault grants.
  • server/vault-move.ts + POST /api/cloud-send/vault/{secret,file} (electron/cloud-send.mjs moveVault) are sealed, fingerprinted and tested (server/cloud-send-vault.e2e.test.ts), but run only inside a move — the move that makes one place your bots' home.
  • Moving from a VPS straight to My Cloud leaves the Vault behind on purpose (electron/vps-cloud-move.mjs: "Saved logins, 1Password and app keys stay on ").

So two places you still switch between by hand (the workspace dropdown, which moves no bots and no chats) each keep their own Vault, with no hint and no way to reconcile it short of moving the bots.

Steps to reproduce
  1. On This computer, Settings → Vault: add a login, and save a secret from a bot's card.
  2. Switch to a paired remote server (workspace dropdown).
  3. Settings → Vault there: neither the login nor the secret is listed. Add either one on the server, switch back to This computer: the server's items are not listed here.
  4. Nothing offers to bring them over. The only copy is a move ("Make my home" / move to dusk cloud), which changes where the bots live.
Version

0.2.17

Platform

macOS

Engine

No response

Logs or screenshots
No error is shown: each place simply lists its own Vault.
Code: server/saved-secrets.ts, server/settings-sync.ts, server/connector-sync.ts,
      server/vault-move.ts, electron/cloud-send.mjs (moveVault), electron/vps-cloud-move.mjs
What would settle it

Either of these closes the report; they are different products, so it needs a decision:

  • Sync it. The pieces exist: per-item sealed writes bound to a purpose and target (vault-move.ts, card-seal.ts), a keyed fingerprint per item for the check, and the same owner-session access settings sync already uses. Add a Vault section to the sync the app runs between the person's own places, last change wins per item, with a delete that stays deleted.
  • Keep it per place, and say so. Label the Vault as belonging to that place (like Settings' "This computer only"), and offer a copy of the Vault to another of your places without moving the bots. A person who has two places should not have to guess which one holds a password a bot needs.
主要言語
TypeScript
スター
277
フォーク
27
平均マージ
2時間 47分
マージ済み PR(30日)
1

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DuskBotAI/duskbot のほかの issue

DuskBotAI/duskbot の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。