Vault doesn't follow between this computer and a remote server

Aperta
#72 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend

Direzione di ricerca

Read server/saved-secrets.ts, server/settings-sync.ts, server/connector-sync.ts, and server/vault-move.ts to understand the per-place Vault and existing sync and move behavior; check server/cloud-send-vault.e2e.test.ts and electron/vps-cloud-move.mjs for related flows. The issue leaves a product decision open between syncing Vault items and keeping them per place with labeling and copy, so get that decision before estimating implementation. Done means the chosen behavior is implemented and the two-place reproduction no longer leaves users guessing or without a way to access their items.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happened

The Vault is per place. Settings, API keys and connector sign-ins follow you across your computers and servers, but saved logins, saved secrets and 1Password do not: an item saved while the window is on a remote server is not on this computer, and one saved here is not on the server. Settings → Vault lists whichever place the window is on without saying so, so the other place's items read as lost.

Nothing keeps the two sides level. The only path a Vault item has out of a machine is a one-time move, and only in the direction of the move:

  • server/saved-secrets.ts — the saved secrets file is "not backed up, exported or synced ... only a move to the person's own Cloud carries each secret".
  • server/settings-sync.ts (WHOLE, FIELDS, SYNCED_SECRETS) and server/connector-sync.ts carry settings, API keys and connector sign-ins; no logins, no saved secrets, no 1Password token or per-vault grants.
  • server/vault-move.ts + POST /api/cloud-send/vault/{secret,file} (electron/cloud-send.mjs moveVault) are sealed, fingerprinted and tested (server/cloud-send-vault.e2e.test.ts), but run only inside a move — the move that makes one place your bots' home.
  • Moving from a VPS straight to My Cloud leaves the Vault behind on purpose (electron/vps-cloud-move.mjs: "Saved logins, 1Password and app keys stay on ").

So two places you still switch between by hand (the workspace dropdown, which moves no bots and no chats) each keep their own Vault, with no hint and no way to reconcile it short of moving the bots.

Steps to reproduce
  1. On This computer, Settings → Vault: add a login, and save a secret from a bot's card.
  2. Switch to a paired remote server (workspace dropdown).
  3. Settings → Vault there: neither the login nor the secret is listed. Add either one on the server, switch back to This computer: the server's items are not listed here.
  4. Nothing offers to bring them over. The only copy is a move ("Make my home" / move to dusk cloud), which changes where the bots live.
Version

0.2.17

Platform

macOS

Engine

No response

Logs or screenshots
No error is shown: each place simply lists its own Vault.
Code: server/saved-secrets.ts, server/settings-sync.ts, server/connector-sync.ts,
      server/vault-move.ts, electron/cloud-send.mjs (moveVault), electron/vps-cloud-move.mjs
What would settle it

Either of these closes the report; they are different products, so it needs a decision:

  • Sync it. The pieces exist: per-item sealed writes bound to a purpose and target (vault-move.ts, card-seal.ts), a keyed fingerprint per item for the check, and the same owner-session access settings sync already uses. Add a Vault section to the sync the app runs between the person's own places, last change wins per item, with a delete that stays deleted.
  • Keep it per place, and say so. Label the Vault as belonging to that place (like Settings' "This computer only"), and offer a copy of the Vault to another of your places without moving the bots. A person who has two places should not have to guess which one holds a password a bot needs.
Lingua principale
TypeScript
Stelle
277
Fork
27
Merge medio
2h 47m
PR unite (30g)
1

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DuskBotAI/duskbot

Tutte le issue di DuskBotAI/duskbot

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.