`/status?network=mainnet` is rate limited although `/status` is exempt

オープン 初心者向け
#662 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 3 日以内に返信

@Joyful12-tech がすでに取り組んでいます。

2026年11月20日 から。

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
84/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
typescript
領域
api, backend, testing

調査の方向性

src/app.tsのprobeの例外処理から始め、そのURLチェックとsrc/middleware/globalRateLimit.tsのルーティング済みパスのチェックを比較します。テストのパターンを確認するため、src/__tests__/rateLimitContract.test.tsとtests/healthProbes.test.tsを読みます。クエリ文字列付きのprobeリクエストが引き続き例外扱いされ、通常のルートでは制限値が低い場合に引き続き429が返ることを示すテストを追加します。既存のレート制限を変更せず、これらのケースが通れば完了です。

索引モデルが issue の本文から書いたものです。

説明

area:reliability difficulty:easy help wanted points:100 Stellar Wave
Background

Health probes must never be throttled. src/app.ts says so at lines 55 to 62 and exempts them at line 174:

allowList: (req) => PROBE_PATHS.has(req.url),

req.url includes the query string. /status takes a network parameter (it reports per network), so a monitor that polls /status?network=mainnet does not match '/status', is counted against the shared per-IP limit of 100 a minute, and can be answered 429 during an incident. That is the exact failure the comment warns about.

The global ceiling next door does it right: src/middleware/globalRateLimit.ts line 44 compares the routed path, not the raw URL.

What to build
  • Make the exemption match the route, not the raw URL, so any query string on /status, /live and /ready is still exempt. The /v1/... forms must be exempt too.
  • Do not exempt anything else. Do not change any limit value.
  • Add tests that set a very low RATE_LIMIT_IP_MAX, call /status?network=testnet more times than the limit, and get no 429; and that a normal route still gets 429.
Where to look
  • src/app.ts lines 62 and 168 to 186
  • src/middleware/globalRateLimit.ts line 44
  • src/__tests__/rateLimitContract.test.ts, tests/healthProbes.test.ts
Done when
  • /status, /live and /ready are exempt with and without a query string, on bare and /v1 paths
  • A non-probe route is still limited, proved by a test
  • No rate limit, scope or CORS rule was removed or loosened
  • npm test passes

Drips Wave · Complexity: Easy · 100 points


Repo: Divinity-Labs/Lens. Install with npm ci, typecheck with npx tsc --noEmit, test with npm test. Tests are vitest. Do not run jest: it reports zero tests and proves nothing.

You cannot reach the production service. Prove your change with local tests and fixtures. Mock the database (pgPool, prisma) the way the existing tests in src/__tests__/ and tests/ do.

Generated files are checked byte for byte by CI. If you add or change a route, edit openapi.yaml by hand and then regenerate the generated files and commit them: npm run openapi:gen (writes openapi.json and the README sections), npm run client:gen (the TypeScript client schema) and, if you touched the GraphQL schema, npm run graphql:schema:gen (writes schema.graphql). The full list is in the scripts section of package.json; also read CONTRIBUTING.md. If a check fails and the diff looks empty, it is line endings: commit with LF.

Prices are high-precision decimals. Do not add a new place where a price or amount goes through parseFloat, Number() or ::float before it reaches the caller.

MCP tools must return exactly the fields the matching REST route returns (tests/mcp-lens.test.ts asserts equality), and the MCP tool modules must not import the database driver directly. Reads are injected.

Do not remove or loosen an existing API-key scope, CORS rule or rate limit, and do not replace src/app.ts wholesale. Past pull requests did both by accident.

Do not weaken a test to make it pass. No real user data, wallet addresses of real users, keys, tokens or connection strings in code, tests or fixtures. Never shorten a Stellar address or contract id; copy it in full from the file that defines it.



Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
2日 6時間
マージ済み PR(30日)
24

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。