`/status?network=mainnet` is rate limited although `/status` is exempt

Aperta Adatta ai principianti
#662 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@Joyful12-tech ci sta già lavorando.

Dal 20/11/2026.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
84/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
api, backend, testing

Direzione di ricerca

Inizia dall’esenzione delle probe in src/app.ts e confronta il controllo dell’URL con il controllo del percorso instradato in src/middleware/globalRateLimit.ts. Leggi src/__tests__/rateLimitContract.test.ts e tests/healthProbes.test.ts per individuare i modelli di test. Aggiungi test che mostrino che le richieste probe con query string restano esenti e che una route normale continua a restituire 429 quando il limite è basso; termina quando questi casi passano con i limiti di frequenza esistenti invariati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:reliability difficulty:easy help wanted points:100 Stellar Wave
Background

Health probes must never be throttled. src/app.ts says so at lines 55 to 62 and exempts them at line 174:

allowList: (req) => PROBE_PATHS.has(req.url),

req.url includes the query string. /status takes a network parameter (it reports per network), so a monitor that polls /status?network=mainnet does not match '/status', is counted against the shared per-IP limit of 100 a minute, and can be answered 429 during an incident. That is the exact failure the comment warns about.

The global ceiling next door does it right: src/middleware/globalRateLimit.ts line 44 compares the routed path, not the raw URL.

What to build
  • Make the exemption match the route, not the raw URL, so any query string on /status, /live and /ready is still exempt. The /v1/... forms must be exempt too.
  • Do not exempt anything else. Do not change any limit value.
  • Add tests that set a very low RATE_LIMIT_IP_MAX, call /status?network=testnet more times than the limit, and get no 429; and that a normal route still gets 429.
Where to look
  • src/app.ts lines 62 and 168 to 186
  • src/middleware/globalRateLimit.ts line 44
  • src/__tests__/rateLimitContract.test.ts, tests/healthProbes.test.ts
Done when
  • /status, /live and /ready are exempt with and without a query string, on bare and /v1 paths
  • A non-probe route is still limited, proved by a test
  • No rate limit, scope or CORS rule was removed or loosened
  • npm test passes

Drips Wave · Complexity: Easy · 100 points


Repo: Divinity-Labs/Lens. Install with npm ci, typecheck with npx tsc --noEmit, test with npm test. Tests are vitest. Do not run jest: it reports zero tests and proves nothing.

You cannot reach the production service. Prove your change with local tests and fixtures. Mock the database (pgPool, prisma) the way the existing tests in src/__tests__/ and tests/ do.

Generated files are checked byte for byte by CI. If you add or change a route, edit openapi.yaml by hand and then regenerate the generated files and commit them: npm run openapi:gen (writes openapi.json and the README sections), npm run client:gen (the TypeScript client schema) and, if you touched the GraphQL schema, npm run graphql:schema:gen (writes schema.graphql). The full list is in the scripts section of package.json; also read CONTRIBUTING.md. If a check fails and the diff looks empty, it is line endings: commit with LF.

Prices are high-precision decimals. Do not add a new place where a price or amount goes through parseFloat, Number() or ::float before it reaches the caller.

MCP tools must return exactly the fields the matching REST route returns (tests/mcp-lens.test.ts asserts equality), and the MCP tool modules must not import the database driver directly. Reads are injected.

Do not remove or loosen an existing API-key scope, CORS rule or rate limit, and do not replace src/app.ts wholesale. Past pull requests did both by accident.

Do not weaken a test to make it pass. No real user data, wallet addresses of real users, keys, tokens or connection strings in code, tests or fixtures. Never shorten a Stellar address or contract id; copy it in full from the file that defines it.



Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
2g 6h
PR unite (30g)
24

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.