Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

A failed venue fetch is indistinguishable from an empty venue

オープン
  • 何か問題がありますか？
#329 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@Stanley471 がすでに取り組んでいます。

2026年10月16日 から。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
nodejs, typescript
領域
backend, observability-sre

調査の方向性

Start with the four catch sites: src/ingesters/amm.ts and src/ingesters/soroswap.ts (both console.error then return []), src/ingest/venues/aquarius.ts, and src/ingest/oracles/reflector.ts (catch returning null with no log). Choose one failure shape (thrown error or result type), then trace how the aggregate consumes these results and where /status reads its data. Run one test file with npx vitest run src/__tests__/yourfile.test.ts, since the repo uses vitest, not jest. Done means a failing venue and an empty venue give different results in a test, failed sources are excluded and retrievable, and reflector logs its failures.

索引モデルが issue の本文から書いたものです。

説明

area:data-integrity difficulty:intermediate help wanted points:150 Stellar Wave
Background

Four places turn a thrown error into "there is nothing here":

src/ingesters/amm.ts:43-44             console.error(…); return []
src/ingesters/soroswap.ts:80-81        console.error(…); return []
src/ingest/venues/aquarius.ts:59-60    console.error(…); return []
src/ingest/oracles/reflector.ts:91-92  } catch { return null }

The caller cannot tell a genuinely empty venue from an unreachable one. For a
price aggregator that distinction is the whole game: if Aquarius is down and we
report zero pools, the aggregate silently reweights onto the venues that did
answer and publishes a price that looks completely normal. Nobody is alerted,
because from the aggregator's point of view nothing failed.

reflector.ts is the sharpest case — it swallows the error without even
logging it, so there is no record that an oracle read failed at all.

What to build

Make failure a distinct outcome from emptiness, all the way to the aggregate.

  • Each of these functions should signal failure to its caller rather than
    returning an empty collection — a thrown error, or a result type carrying the
    distinction. Pick one shape and use it in all four.
  • A venue that failed must be excluded from the aggregate, not counted as
    contributing zero.
  • Record which venues failed on the aggregate, so /status and L167 can report it.
  • No catch {} without at least a log line.
Acceptance criteria
  • A failing venue and an empty venue produce different results, asserted by a test
  • A failing venue does not reweight the aggregate as though it answered with nothing
  • reflector.ts logs its failures
  • The set of failed sources for a given aggregate is retrievable, not just logged

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
1日 15時間
マージ済み PR（30日）
28

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。