Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

A failed venue fetch is indistinguishable from an empty venue

Aperta
  • Qualcosa non va?
#329 4 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@flare-999 ci sta già lavorando.

Dal 16/10/2026.

  • #465 di @flare-999 — aperta
  • #467 di @sparkysolutions10-pixel — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
nodejs, typescript
Ambito
backend, observability-sre

Direzione di ricerca

Start with the four catch sites: src/ingesters/amm.ts and src/ingesters/soroswap.ts (both console.error then return []), src/ingest/venues/aquarius.ts, and src/ingest/oracles/reflector.ts (catch returning null with no log). Choose one failure shape (thrown error or result type), then trace how the aggregate consumes these results and where /status reads its data. Run one test file with npx vitest run src/__tests__/yourfile.test.ts, since the repo uses vitest, not jest. Done means a failing venue and an empty venue give different results in a test, failed sources are excluded and retrievable, and reflector logs its failures.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:data-integrity difficulty:intermediate help wanted points:150 Stellar Wave
Background

Four places turn a thrown error into "there is nothing here":

src/ingesters/amm.ts:43-44             console.error(…); return []
src/ingesters/soroswap.ts:80-81        console.error(…); return []
src/ingest/venues/aquarius.ts:59-60    console.error(…); return []
src/ingest/oracles/reflector.ts:91-92  } catch { return null }

The caller cannot tell a genuinely empty venue from an unreachable one. For a
price aggregator that distinction is the whole game: if Aquarius is down and we
report zero pools, the aggregate silently reweights onto the venues that did
answer and publishes a price that looks completely normal. Nobody is alerted,
because from the aggregator's point of view nothing failed.

reflector.ts is the sharpest case — it swallows the error without even
logging it, so there is no record that an oracle read failed at all.

What to build

Make failure a distinct outcome from emptiness, all the way to the aggregate.

  • Each of these functions should signal failure to its caller rather than
    returning an empty collection — a thrown error, or a result type carrying the
    distinction. Pick one shape and use it in all four.
  • A venue that failed must be excluded from the aggregate, not counted as
    contributing zero.
  • Record which venues failed on the aggregate, so /status and L167 can report it.
  • No catch {} without at least a log line.
Acceptance criteria
  • A failing venue and an empty venue produce different results, asserted by a test
  • A failing venue does not reweight the aggregate as though it answered with nothing
  • reflector.ts logs its failures
  • The set of failed sources for a given aggregate is retrievable, not just logged

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
1g 9h
PR unite (30g)
34

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.