Add http.route support for Spring Cloud Gateway Path predicates
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 62/100
- issue の種類
- 機能追加
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- java, spring, spring-boot
- 領域
- backend, observability
調査の方向性
Start in spring-webflux-5.0/src/main/java/datadog/trace/instrumentation/springwebflux/server/HandlerAdapterAdvice.java, then read Spring Cloud Gateway's PathRoutePredicateFactory and RoutePredicateHandlerMapping sources. Trace the GATEWAY_ROUTE_ATTR, GATEWAY_PREDICATE_MATCHED_PATH_ATTR, and route ID attributes, ensuring the matched path belongs to the selected route. Done means inbound Gateway spans use the stable matched path for http.route and route-based resource naming without query or StripPrefix effects.
索引モデルが issue の本文から書いたものです。
説明
Library Name
Spring Cloud Gateway
Library Version(s)
Spring Cloud Gateway 3.1.5
Spring Cloud 2021.0.5
Spring Boot 2.7.8
Describe the feature you would like
Inbound Reactor Netty server spans created for Spring Cloud Gateway requests should use the matched Gateway Path predicate as the http.route tag.
For example, given this route:
spring:
cloud:
gateway:
routes:
- id: api-service
uri: http://localhost:8081
predicates:
- Path=/api/**
filters:
- StripPrefix=1
A request such as:
GET /api/users/123?page=1
should produce:
operation.name: netty.request
http.route: /api/**
When route-based server resource naming is enabled, the resource name should also become:
GET /api/**
The matched predicate is preferable to the concrete request path because it is stable and low-cardinality.
Is your feature request related to a problem?
Yes. Spring Cloud Gateway does not publish its matched route through the WebFlux standard HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE.
Instead, it stores routing information in Gateway-specific exchange attributes:
GATEWAY_ROUTE_ATTR
GATEWAY_PREDICATE_MATCHED_PATH_ATTR
GATEWAY_PREDICATE_MATCHED_PATH_ROUTE_ID_ATTR
The current Spring WebFlux instrumentation only reads:
exchange.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE)
As a result, the inbound Reactor Netty span can contain:
operation.name: netty.request
resource.name: GET /api/users/123
http.url: http://localhost:8080/api/users/123?page=1
http.route: absent
Spring Cloud Gateway already contains the low-cardinality matched pattern /api/**, but the tracer does not consume it.
Relevant sources:
- dd-trace-java HandlerAdapterAdvice
- Spring Cloud Gateway PathRoutePredicateFactory
- Spring Cloud Gateway RoutePredicateHandlerMapping
- Spring Cloud Gateway GatewayPathTagsProvider
When reading the Gateway-specific matched path, the implementation should verify that GATEWAY_PREDICATE_MATCHED_PATH_ROUTE_ID_ATTR belongs to the route in GATEWAY_ROUTE_ATTR. This avoids using a path left by an earlier candidate route whose remaining predicates did not match.
Describe alternatives you have considered
-
Setting
http.routefrom the concrete request URL. This is not suitable because IDs and other dynamic path segments would create high-cardinality route values. -
Manually tagging the active span in a Gateway filter. This couples application code to the tracing API and duplicates information already available from Spring Cloud Gateway.
-
Replacing
RoutePredicateHandlerMappingin the application to copy the matched Gateway path intoBEST_MATCHING_PATTERN_ATTRIBUTE. This is intrusive and requires every Spring Cloud Gateway application to implement the same workaround.
Tracer-level support for Spring Cloud Gateway route attributes would provide consistent behavior without application-specific tracing code.
Additional context
Observed with dd-java-agent 1.63.4.
The issue applies to inbound Spring Cloud Gateway requests handled by Spring WebFlux and Reactor Netty. Query parameters and StripPrefix filters should not affect the ingress route value.
- 主要言語
- Java
- スター
- 737
- フォーク
- 361
- 平均マージ
- 3日 20時間
- マージ済み PR(30日)
- 173
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
DataDog/dd-trace-java のほかの issue
-
type: feature request
難易度 1/5 1〜3時間 初心者へのやさしさ 70/100
DataDog/dd-trace-java#10245 · コメント 1 件 ·
-
type: bug report
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
DataDog/dd-trace-java#12597 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
DataDog/dd-trace-java#12540 · コメント 4 件 · 担当者 1 名 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 25/100
DataDog/dd-trace-java#12480 ·
-
comp: tooling type: bug report
DataDog/dd-trace-java#12469 · リアクション 1 件 · 担当者 1 名 ·
DataDog/dd-trace-java の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
HL7/fhir-ig-publisher#1375 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
-
Flaky: a relaunched catch-up replay can still report catching up right after its marker is written オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
johanhaleby/occurrent#1134 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
objectionary/jeo-maven-plugin#1811 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100