Add http.route support for Spring Cloud Gateway Path predicates
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 62/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- java, spring, spring-boot
- Ambito
- backend, observability
Direzione di ricerca
Start in spring-webflux-5.0/src/main/java/datadog/trace/instrumentation/springwebflux/server/HandlerAdapterAdvice.java, then read Spring Cloud Gateway's PathRoutePredicateFactory and RoutePredicateHandlerMapping sources. Trace the GATEWAY_ROUTE_ATTR, GATEWAY_PREDICATE_MATCHED_PATH_ATTR, and route ID attributes, ensuring the matched path belongs to the selected route. Done means inbound Gateway spans use the stable matched path for http.route and route-based resource naming without query or StripPrefix effects.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Library Name
Spring Cloud Gateway
Library Version(s)
Spring Cloud Gateway 3.1.5
Spring Cloud 2021.0.5
Spring Boot 2.7.8
Describe the feature you would like
Inbound Reactor Netty server spans created for Spring Cloud Gateway requests should use the matched Gateway Path predicate as the http.route tag.
For example, given this route:
spring:
cloud:
gateway:
routes:
- id: api-service
uri: http://localhost:8081
predicates:
- Path=/api/**
filters:
- StripPrefix=1
A request such as:
GET /api/users/123?page=1
should produce:
operation.name: netty.request
http.route: /api/**
When route-based server resource naming is enabled, the resource name should also become:
GET /api/**
The matched predicate is preferable to the concrete request path because it is stable and low-cardinality.
Is your feature request related to a problem?
Yes. Spring Cloud Gateway does not publish its matched route through the WebFlux standard HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE.
Instead, it stores routing information in Gateway-specific exchange attributes:
GATEWAY_ROUTE_ATTR
GATEWAY_PREDICATE_MATCHED_PATH_ATTR
GATEWAY_PREDICATE_MATCHED_PATH_ROUTE_ID_ATTR
The current Spring WebFlux instrumentation only reads:
exchange.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE)
As a result, the inbound Reactor Netty span can contain:
operation.name: netty.request
resource.name: GET /api/users/123
http.url: http://localhost:8080/api/users/123?page=1
http.route: absent
Spring Cloud Gateway already contains the low-cardinality matched pattern /api/**, but the tracer does not consume it.
Relevant sources:
- dd-trace-java HandlerAdapterAdvice
- Spring Cloud Gateway PathRoutePredicateFactory
- Spring Cloud Gateway RoutePredicateHandlerMapping
- Spring Cloud Gateway GatewayPathTagsProvider
When reading the Gateway-specific matched path, the implementation should verify that GATEWAY_PREDICATE_MATCHED_PATH_ROUTE_ID_ATTR belongs to the route in GATEWAY_ROUTE_ATTR. This avoids using a path left by an earlier candidate route whose remaining predicates did not match.
Describe alternatives you have considered
-
Setting
http.routefrom the concrete request URL. This is not suitable because IDs and other dynamic path segments would create high-cardinality route values. -
Manually tagging the active span in a Gateway filter. This couples application code to the tracing API and duplicates information already available from Spring Cloud Gateway.
-
Replacing
RoutePredicateHandlerMappingin the application to copy the matched Gateway path intoBEST_MATCHING_PATTERN_ATTRIBUTE. This is intrusive and requires every Spring Cloud Gateway application to implement the same workaround.
Tracer-level support for Spring Cloud Gateway route attributes would provide consistent behavior without application-specific tracing code.
Additional context
Observed with dd-java-agent 1.63.4.
The issue applies to inbound Spring Cloud Gateway requests handled by Spring WebFlux and Reactor Netty. Query parameters and StripPrefix filters should not affect the ingress route value.
- Lingua principale
- Java
- Stelle
- 737
- Fork
- 361
- Merge medio
- 3g 20h
- PR unite (30g)
- 173
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di DataDog/dd-trace-java
-
type: feature request
Difficoltà 1/5 1-3 ore Idoneità per principianti 70/100
DataDog/dd-trace-java#10245 · 1 commento ·
-
type: bug report
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
DataDog/dd-trace-java#12597 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
DataDog/dd-trace-java#12540 · 4 commenti · 1 assegnatario ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 25/100
DataDog/dd-trace-java#12480 ·
-
comp: tooling type: bug report
DataDog/dd-trace-java#12469 · 1 reazione · 1 assegnatario ·
Tutte le issue di DataDog/dd-trace-java
Issue simili
-
certification
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 80/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
[BUG] ECR GetAuthorizationToken returns a proxyEndpoint for the default region, not the request's Apertabug ecr
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Needs: Triage Type: Feature request
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
AntennaPod/AntennaPod#8794 ·
-
agentic-workflows
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
github/copilot-sdk#2760 ·