Request a Copy: repeated clicks on submit / send create duplicate requests and emails

オープン
  • 何か問題がありますか？
#6,541 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
40/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
angular, typescript
領域
frontend

調査の方向性

The three affected actions are onSubmit() in the Request a Copy page and grant() and deny() in the response-form components, which the issue links to bitstream-request-a-copy-page, grant-request-copy and deny-request-copy. Check where each button's disabled binding is set and where the REST call is dispatched, and confirm nothing guards against a call already in flight. Done means one click produces one request, the button is disabled with a spinner while pending, and it re-enables after a network error. The author says they plan to open a PR, so coordinate before starting.

索引モデルが issue の本文から書いたものです。

説明

bug needs triage

Describe the bug

The Request a Copy form and the grant/deny email response forms do not prevent repeated submissions while a request is in flight. Each additional click on the submit button fires another REST request, causing the backend to create several identical item requests and dispatch multiple duplicate notification emails to authors and submitters.

Affected buttons:

  • "Request copy" on the initial request form (bitstream-request-a-copy-page)

  • "Send" on the grant email form (grant-request-copy)

  • "Send" on the deny email form (deny-request-copy)

  • DSpace Version(s): Seen on DSpace 10.1 and confirmed on main. The buttons are only disabled when the form is invalid (requestCopyForm.invalid), but onSubmit(), grant(), and deny() have no in-flight execution check.

  • Web Browser: Chrome 131, Firefox 132 (reproducible across all browsers).

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to an item containing a restricted bitstream and click the file link to reach the Request a Copy form.
  2. Fill in the required fields (name, email, and message).
  3. In browser Developer Tools (Network tab), throttle network speed (e.g. to "Slow 3G") so the REST request takes 2–3 seconds.
  4. Click the "Request copy" button 3 or 4 times rapidly before the page redirects.
  5. In the browser Network tab, observe multiple parallel POST /server/api/core/itemrequests requests sent (one for each click).
  6. The item contact receives multiple duplicate email notifications for the same request.

(The same behavior can be reproduced on the grant and deny response forms by clicking "Send" repeatedly).

Expected behavior

  • One submission should create exactly one item request and send one set of emails.
  • While the request is in flight, the button should immediately be disabled and display a loading/spinner state.
  • If the request encounters a network error, the button should become active again so the user can retry.

Related work

I have a UI fix ready (in-flight guard, disabled state, and spinner icon on all three buttons) and will open a pull request for this issue.

Question for maintainers: Would you also recommend adding a backend safeguard in DSpace/DSpace (such as rate-limiting or deduplicating identical requests within a short timeframe), or is the UI in-flight guard sufficient?

主要言語
TypeScript
スター
180
フォーク
577
平均マージ
2日 1時間
マージ済み PR（30日）
100

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DSpace/dspace-angular のほかの issue

DSpace/dspace-angular の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。