Request a Copy: repeated clicks on submit / send create duplicate requests and emails

Aperta
  • Qualcosa non va?
#6,541 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
40/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
angular, typescript
Ambito
frontend

Direzione di ricerca

The three affected actions are onSubmit() in the Request a Copy page and grant() and deny() in the response-form components, which the issue links to bitstream-request-a-copy-page, grant-request-copy and deny-request-copy. Check where each button's disabled binding is set and where the REST call is dispatched, and confirm nothing guards against a call already in flight. Done means one click produces one request, the button is disabled with a spinner while pending, and it re-enables after a network error. The author says they plan to open a PR, so coordinate before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug needs triage

Describe the bug

The Request a Copy form and the grant/deny email response forms do not prevent repeated submissions while a request is in flight. Each additional click on the submit button fires another REST request, causing the backend to create several identical item requests and dispatch multiple duplicate notification emails to authors and submitters.

Affected buttons:

  • "Request copy" on the initial request form (bitstream-request-a-copy-page)

  • "Send" on the grant email form (grant-request-copy)

  • "Send" on the deny email form (deny-request-copy)

  • DSpace Version(s): Seen on DSpace 10.1 and confirmed on main. The buttons are only disabled when the form is invalid (requestCopyForm.invalid), but onSubmit(), grant(), and deny() have no in-flight execution check.

  • Web Browser: Chrome 131, Firefox 132 (reproducible across all browsers).

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to an item containing a restricted bitstream and click the file link to reach the Request a Copy form.
  2. Fill in the required fields (name, email, and message).
  3. In browser Developer Tools (Network tab), throttle network speed (e.g. to "Slow 3G") so the REST request takes 2–3 seconds.
  4. Click the "Request copy" button 3 or 4 times rapidly before the page redirects.
  5. In the browser Network tab, observe multiple parallel POST /server/api/core/itemrequests requests sent (one for each click).
  6. The item contact receives multiple duplicate email notifications for the same request.

(The same behavior can be reproduced on the grant and deny response forms by clicking "Send" repeatedly).

Expected behavior

  • One submission should create exactly one item request and send one set of emails.
  • While the request is in flight, the button should immediately be disabled and display a loading/spinner state.
  • If the request encounters a network error, the button should become active again so the user can retry.

Related work

I have a UI fix ready (in-flight guard, disabled state, and spinner icon on all three buttons) and will open a pull request for this issue.

Question for maintainers: Would you also recommend adding a backend safeguard in DSpace/DSpace (such as rate-limiting or deduplicating identical requests within a short timeframe), or is the UI in-flight guard sufficient?

Lingua principale
TypeScript
Stelle
180
Fork
577
Merge medio
2g 1h
PR unite (30g)
100

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DSpace/dspace-angular

Tutte le issue di DSpace/dspace-angular

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.