field-parser not applying the visibility configuration

オープン
#5,854 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@AdamF42 がすでに取り組んでいます。

2026年10月15日 から。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
静か
技術スタック
angular, typescript
領域
frontend

調査の方向性

Start with src/app/submission/utils/visibility.util.ts and the section-visibility and submission-scope-type models it uses, then check whether the backend's SubmissionFormConverter.java still sends the visibility data in the old 9.2 format. Reproduce by setting a workflow visibility and readonly on dc.title in submission-forms.xml, then confirm whether the field is disabled. Done means the field is read-only in the submission form, or the cause is confirmed as backend-only and the issue is moved there.

索引モデルが issue の本文から書いたものです。

説明

bug needs triage

Describe the bug

When a metadata field is configured to have a limited visibility in the back-end, this configuration is not being applied in the front-end.

I noticed that there were some changes to the code related to this functionality on the front-end, but no equivalent changes were made on the back-end.

In the current front-end, the main code that applies the configuration in a given field is:
https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/submission/utils/visibility.util.ts#L19-L23

and

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/models/section-visibility.model.ts#L12

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/models/section-visibility.model.ts#L4-L7

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/submission-scope-type.ts#L1-L5

However, the returned data from the back-end still returns in the same format as it was in 9.2 (blame is from 8 years ago).

Therefore, I'm not sure if it is a front-end bug or a back-end (maybe a missing PR?).

To Reproduce

Steps to reproduce the behavior:

  1. In the back-end, edit submission-forms.xml by adding to some field (dc.title for example) the following config:
<visibility>workflow</visibility>
<readonly>readonly</readonly>

This should make the existing field read-only (disabled) during submission.
2. Start/restart the DSpace backend.
3. Start/edit a submission.
4. The field will still be available for editing. If you try this same configuration in DSpace 9.2, the field will be disabled (works even if you use the DSpace 10.0 backend alongside the DSpace 9.2 frontend).

Expected behavior

The visibility configuration from the back-end should reflect in the forms fields.

主要言語
TypeScript
スター
180
フォーク
577
平均マージ
2日 1時間
マージ済み PR(30日)
100

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DSpace/dspace-angular のほかの issue

DSpace/dspace-angular の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。