field-parser not applying the visibility configuration

Abierto
  • ¿Algo no está bien?
#5,854 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@AdamF42 ya está trabajando en esto.

Desde el 15/10/2026.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
angular, typescript
Área
frontend

Línea de trabajo

Start with src/app/submission/utils/visibility.util.ts and the section-visibility and submission-scope-type models it uses, then check whether the backend's SubmissionFormConverter.java still sends the visibility data in the old 9.2 format. Reproduce by setting a workflow visibility and readonly on dc.title in submission-forms.xml, then confirm whether the field is disabled. Done means the field is read-only in the submission form, or the cause is confirmed as backend-only and the issue is moved there.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug needs triage

Describe the bug

When a metadata field is configured to have a limited visibility in the back-end, this configuration is not being applied in the front-end.

I noticed that there were some changes to the code related to this functionality on the front-end, but no equivalent changes were made on the back-end.

In the current front-end, the main code that applies the configuration in a given field is:
https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/submission/utils/visibility.util.ts#L19-L23

and

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/models/section-visibility.model.ts#L12

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/models/section-visibility.model.ts#L4-L7

https://github.com/DSpace/dspace-angular/blob/7f59f6cf99f0d1fb4b2abe46e9f24a5e1ee01a49/src/app/core/submission/submission-scope-type.ts#L1-L5

However, the returned data from the back-end still returns in the same format as it was in 9.2 (blame is from 8 years ago).

Therefore, I'm not sure if it is a front-end bug or a back-end (maybe a missing PR?).

To Reproduce

Steps to reproduce the behavior:

  1. In the back-end, edit submission-forms.xml by adding to some field (dc.title for example) the following config:
<visibility>workflow</visibility>
<readonly>readonly</readonly>

This should make the existing field read-only (disabled) during submission.
2. Start/restart the DSpace backend.
3. Start/edit a submission.
4. The field will still be available for editing. If you try this same configuration in DSpace 9.2, the field will be disabled (works even if you use the DSpace 10.0 backend alongside the DSpace 9.2 frontend).

Expected behavior

The visibility configuration from the back-end should reflect in the forms fields.

Lenguaje dominante
TypeScript
Estrellas
180
Forks
577
Merge medio
2 d 1 h
PR fusionados (30 d)
100

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DSpace/dspace-angular

Todos los issues de DSpace/dspace-angular

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.