replace_ops does not re-mint inputs[].grow_id — bulk-replayed autogrow slots inherit the source document's identities
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
Read docs/op-vocabulary-v1.md §8.8 and inspect replace_ops to trace how it remaps inputs[].link and handles inputs[].grow_id. Compare the op replay path with the apply_specs behavior described in the issue. The owner must decide whether to remap grow_id or document why it is carried through; done means that decision is implemented and the acceptance condition in the issue is met.
索引モデルが issue の本文から書いたものです。
説明
Problem
replace_ops re-mints every node and link identity, but it does not re-mint inputs[].grow_id on an autogrow slot. The grown slots in the emitted add_node payload keep the source document's link ids as their grow_id.
docs/op-vocabulary-v1.md §8.8 states the rule as "Identity is re-minted, never inherited… Every node and link gets a fresh mint_id and every interior reference (inputs[].link, outputs[].links, the links tuples) is remapped onto it." grow_id is an interior identity reference and is not in that list, so it is carried through verbatim.
Repro
Build a workflow whose BatchImagesNode autogrow base has three wired slots, then emit and replay a batch:
source document: images.image0 link=1369904620697626 grow_id=1369904620697626
add_node payload: images.image0 link=4047451378665163 grow_id=1369904620697626 <-- stale
after apply_op: images.image0 link=4047451378665163 grow_id=1369904620697626 <-- stale
after apply_specs: images.image0 link=<fresh> grow_id=<fresh, == link>
The link is remapped; the grow_id is not. _apply_connect sets grow_id to the newly minted link id, which is why the spec path (which re-mints each node from the catalog and wires it with real connect ops) comes out consistent while the op path does not.
Impact
- Duplicate identity across replicas.
grow_idis the convergence identity of a grown slot. Two documents seeded from the same template byreplace_opsend up with grown slots that share agrow_idwhile holding different link ids — the duplicate-identity-on-first-merge hazard §1.5 / §8.6 exist to prevent. The whole reasonreplace_opsre-mints is to avoid exactly this. - The two consumers of one artifact diverge. §8.8 promises the same array replays through
apply_opandapply_specs. After the fix in #848 both paths reproduce the same slot names, wiring and link count, but theirgrow_idvalues differ in kind: the op path inherits the source's, the spec path mints fresh ones equal to the link id.
Expected
Either replace_ops remaps grow_id alongside inputs[].link, or §8.8 states explicitly that grow_id is carried verbatim and says why that is safe. The current state is neither — the doc enumerates what gets remapped and omits this field without comment, so the behaviour is undocumented rather than decided.
This touches frozen mint semantics, so it needs an owner ruling rather than a drive-by patch.
Provenance
Raised as a review finding on https://github.com/Comfy-Org/comfy-cli/pull/848 (tests/comfy_cli/command/test_workflow_edit.py line 2239) and verified by direct probe at head 8da9bf27ec8b0f56fab0ac23aad2695fbc777ed3. #848 deliberately does not assert grow_id parity between the two paths, so it neither fixes nor pins this; see #1034 for the separate _slot_ref defect that PR does fix.
Task Decomposition
Not decomposed: the investigation is complete and the remaining work is one owner decision followed by either a few-line remap in replace_ops or a documentation sentence in §8.8. Complexity tier: analytical (the decision), trivial (the change). Dependency: an owner ruling on frozen mint semantics. Acceptance: grow_id values after an apply_op replay are disjoint from the source document's, or §8.8 records why they need not be.
- 主要言語
- Python
- スター
- 1k
- フォーク
- 176
- 平均マージ
- 1日 11時間
- マージ済み PR（30日）
- 87
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Comfy-Org/comfy-cli のほかの issue
-
test_file_utils umask tests assert against a umask the code never reads (import-time _UMASK), so they only pass on a 0o022 host対応中かも @neverbiasu が 10 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
Comfy-Org/comfy-cli#907 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
Comfy-Org/comfy-cli#781 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
`comfy launch --background` fails with FileNotFoundError when comfy-cli is invoked by path対応中かも @RaphaelFakhri が 42 日前に担当しました。 オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Comfy-Org/comfy-cli#691 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
Comfy-Org/comfy-cli#670 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
Comfy-Org/comfy-cli の issue をすべて見る
似ている issue
-
add entry to blockオープン
難易度 1/5 1時間未満 初心者へのやさしさ 65/100
StevenBlack/hosts#3299 ·
-
`garak --report` overwrites the input report when its name has no ".report"対応中かも @0z5a が今日担当しました。 オープンneeds-triage
難易度 2/5 半日 初心者へのやさしさ 72/100
メンテナーはふだん 2 日以内に返信
-
plot_graph crashes when a mesh node has no m2m edge対応中かも @tygvi が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
mllam/neural-lam#883 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
future-agi/future-agi#4092 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
transcript analytics: a text whose only protected spans the prose pass redacts is withheld wholeオープン
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
WingedGuardian/GENesis-AGI#4641 ·
メンテナーはふだん 1 日以内に返信