replace_ops does not re-mint inputs[].grow_id — bulk-replayed autogrow slots inherit the source document's identities

Aperta
  • Qualcosa non va?
#1,035 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
cli

Direzione di ricerca

Read docs/op-vocabulary-v1.md §8.8 and inspect replace_ops to trace how it remaps inputs[].link and handles inputs[].grow_id. Compare the op replay path with the apply_specs behavior described in the issue. The owner must decide whether to remap grow_id or document why it is carried through; done means that decision is implemented and the acceptance condition in the issue is met.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Problem

replace_ops re-mints every node and link identity, but it does not re-mint inputs[].grow_id on an autogrow slot. The grown slots in the emitted add_node payload keep the source document's link ids as their grow_id.

docs/op-vocabulary-v1.md §8.8 states the rule as "Identity is re-minted, never inherited… Every node and link gets a fresh mint_id and every interior reference (inputs[].link, outputs[].links, the links tuples) is remapped onto it." grow_id is an interior identity reference and is not in that list, so it is carried through verbatim.

Repro

Build a workflow whose BatchImagesNode autogrow base has three wired slots, then emit and replay a batch:

source document:  images.image0  link=1369904620697626  grow_id=1369904620697626
add_node payload: images.image0  link=4047451378665163  grow_id=1369904620697626   <-- stale
after apply_op:   images.image0  link=4047451378665163  grow_id=1369904620697626   <-- stale
after apply_specs: images.image0 link=<fresh>           grow_id=<fresh, == link>

The link is remapped; the grow_id is not. _apply_connect sets grow_id to the newly minted link id, which is why the spec path (which re-mints each node from the catalog and wires it with real connect ops) comes out consistent while the op path does not.

Impact

  1. Duplicate identity across replicas. grow_id is the convergence identity of a grown slot. Two documents seeded from the same template by replace_ops end up with grown slots that share a grow_id while holding different link ids — the duplicate-identity-on-first-merge hazard §1.5 / §8.6 exist to prevent. The whole reason replace_ops re-mints is to avoid exactly this.
  2. The two consumers of one artifact diverge. §8.8 promises the same array replays through apply_op and apply_specs. After the fix in #848 both paths reproduce the same slot names, wiring and link count, but their grow_id values differ in kind: the op path inherits the source's, the spec path mints fresh ones equal to the link id.

Expected

Either replace_ops remaps grow_id alongside inputs[].link, or §8.8 states explicitly that grow_id is carried verbatim and says why that is safe. The current state is neither — the doc enumerates what gets remapped and omits this field without comment, so the behaviour is undocumented rather than decided.

This touches frozen mint semantics, so it needs an owner ruling rather than a drive-by patch.

Provenance

Raised as a review finding on https://github.com/Comfy-Org/comfy-cli/pull/848 (tests/comfy_cli/command/test_workflow_edit.py line 2239) and verified by direct probe at head 8da9bf27ec8b0f56fab0ac23aad2695fbc777ed3. #848 deliberately does not assert grow_id parity between the two paths, so it neither fixes nor pins this; see #1034 for the separate _slot_ref defect that PR does fix.

Task Decomposition

Not decomposed: the investigation is complete and the remaining work is one owner decision followed by either a few-line remap in replace_ops or a documentation sentence in §8.8. Complexity tier: analytical (the decision), trivial (the change). Dependency: an owner ruling on frozen mint semantics. Acceptance: grow_id values after an apply_op replay are disjoint from the source document's, or §8.8 records why they need not be.

Lingua principale
Python
Stelle
1k
Fork
176
Merge medio
1g 11h
PR unite (30g)
87

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Comfy-Org/comfy-cli

Tutte le issue di Comfy-Org/comfy-cli

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.