Discussion: System Settings, power menu and confirmations inside Puppy instead of separate apps

オープン
#110 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp
領域
desktop, devtools

調査の方向性

Start by reading the discussion in issues #46, #107, and #5 alongside the current System tab and appd behavior described here. The proposed first step is to move existing brightness, Resize Home, Eject TF-2, reboot, and power-off flows into Puppy; the direction and scope still need maintainer agreement before implementation. Done means the agreed first step works in an image tested on the device, with settings changes and confirmations behaving as specified.

索引モデルが issue の本文から書いたものです。

説明

Hi Jeremy,

First, sorry for going quiet on the PRs for a while. I got deep into the Stardew Valley and Luanti ports, Luanti most of all: besides the engine work to fit it in 512 MB, I spent a lot of time on mods and optimizations (#83). I think Luanti is mature enough now to rest for a while, so I'm back on the goodluckOS PRs.

I'd like to open a discussion about where System Settings and the system dialogs should live. In #46 you said you still wanted to think over how the user-facing graphical programs should be structured, and #107 mentions a new Settings app too, so it seems a good moment to agree on a direction before more code goes either way.

On main today, System Settings, Resize Home, Reboot, Power Off and Eject TF-2 are separate entries in the System tab, each one its own program (system-settings, resize-home, are-you-sure, a umount). Since appd never runs the launcher and an app at the same time, opening any of them closes Puppy, shows the loading screen and starts the program, and when it exits Puppy starts again and reloads the library. That is the right flow for a game, but it is a long round trip to change the brightness, and answering "No" to Power Off still costs a full launcher restart.

In my build I went the other way. System Settings is a screen inside Puppy, opened with START: there is no loading screen on the way in or out, and the launcher comes back exactly as it was. Resize Home is a page under Storage, with the card and partition sizes and a confirmation before it reboots. POWER in the launcher (and in Settings) opens a small power menu drawn over the current screen, with Display off, Restart and Shut down, the last two asking first. Every confirmation (restart, shut down, resize HOME, restore defaults, move a game to the trash) is the same floating dialog, with the safe choice selected by default. Inside a game, POWER still only turns the screen off.

To keep this from turning Puppy into one big file, its code is split in two layers. The screens (launcher, on-screen keyboard, dialogs, settings, button tester) run as a stack in one process, and everything that touches the device or a file (mixer, backlight, prefs, clock, storage) goes through small classes under src/system/, one owner for each file or sysfs node. If a separate app ever needs the same settings, that layer could become a shared library without touching the screens.

There are costs, of course. Puppy grows, and a bug in Settings takes the launcher down with it, while a separate app only crashes itself. Separate apps are also easier for other people to write and ship, like the custom apps in #103 and #107. I think both models can live together: the system things that need the launcher's state or should feel instant (settings, power, confirmations, storage) inside Puppy, and real applications (terminal tools, a music player, a gallery, custom apps) as apps run by appd. glos-setup stays its own program either way, since it runs before the launcher.

Power options over the launcher, the restart confirmation, and the same menu over System Settings:

Image

System Settings with its sections, the Storage page and the Resize Home page:

Image

Confirmations: resize HOME, restore default settings, and moving a game to the trash:

Image

If you like the direction, I'd do it in small steps. The first PR would only move what main has today into Puppy, with no new options: brightness (kept across reboots, which #5 mentions is missing), Resize Home, Eject TF-2, and the power menu with the confirmation dialog in place of the Reboot and Power Off entries and are-you-sure. After that, one PR for each group of settings from my build, each one small enough to review on its own: volume and audio output, launcher view and tabs, language and font, the in-game overlay, date and time, power mode, the confirm button and the button tester. All of this is ready and tested on my console. As with my other PRs, I'd test each PR's own image on the device and say where AI was used.

And if you'd rather keep settings as separate apps, I can adapt these pages to that model instead. What do you think?

主要言語
C++
スター
54
フォーク
8
平均マージ
16日 19時間
マージ済み PR(30日)
4

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

CodeZombie/goodluckOS のほかの issue

CodeZombie/goodluckOS の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。