Discussion: System Settings, power menu and confirmations inside Puppy instead of separate apps
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
Direzione di ricerca
Start by reading the discussion in issues #46, #107, and #5 alongside the current System tab and appd behavior described here. The proposed first step is to move existing brightness, Resize Home, Eject TF-2, reboot, and power-off flows into Puppy; the direction and scope still need maintainer agreement before implementation. Done means the agreed first step works in an image tested on the device, with settings changes and confirmations behaving as specified.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Hi Jeremy,
First, sorry for going quiet on the PRs for a while. I got deep into the Stardew Valley and Luanti ports, Luanti most of all: besides the engine work to fit it in 512 MB, I spent a lot of time on mods and optimizations (#83). I think Luanti is mature enough now to rest for a while, so I'm back on the goodluckOS PRs.
I'd like to open a discussion about where System Settings and the system dialogs should live. In #46 you said you still wanted to think over how the user-facing graphical programs should be structured, and #107 mentions a new Settings app too, so it seems a good moment to agree on a direction before more code goes either way.
On main today, System Settings, Resize Home, Reboot, Power Off and Eject TF-2 are separate entries in the System tab, each one its own program (system-settings, resize-home, are-you-sure, a umount). Since appd never runs the launcher and an app at the same time, opening any of them closes Puppy, shows the loading screen and starts the program, and when it exits Puppy starts again and reloads the library. That is the right flow for a game, but it is a long round trip to change the brightness, and answering "No" to Power Off still costs a full launcher restart.
In my build I went the other way. System Settings is a screen inside Puppy, opened with START: there is no loading screen on the way in or out, and the launcher comes back exactly as it was. Resize Home is a page under Storage, with the card and partition sizes and a confirmation before it reboots. POWER in the launcher (and in Settings) opens a small power menu drawn over the current screen, with Display off, Restart and Shut down, the last two asking first. Every confirmation (restart, shut down, resize HOME, restore defaults, move a game to the trash) is the same floating dialog, with the safe choice selected by default. Inside a game, POWER still only turns the screen off.
To keep this from turning Puppy into one big file, its code is split in two layers. The screens (launcher, on-screen keyboard, dialogs, settings, button tester) run as a stack in one process, and everything that touches the device or a file (mixer, backlight, prefs, clock, storage) goes through small classes under src/system/, one owner for each file or sysfs node. If a separate app ever needs the same settings, that layer could become a shared library without touching the screens.
There are costs, of course. Puppy grows, and a bug in Settings takes the launcher down with it, while a separate app only crashes itself. Separate apps are also easier for other people to write and ship, like the custom apps in #103 and #107. I think both models can live together: the system things that need the launcher's state or should feel instant (settings, power, confirmations, storage) inside Puppy, and real applications (terminal tools, a music player, a gallery, custom apps) as apps run by appd. glos-setup stays its own program either way, since it runs before the launcher.
Power options over the launcher, the restart confirmation, and the same menu over System Settings:
System Settings with its sections, the Storage page and the Resize Home page:
Confirmations: resize HOME, restore default settings, and moving a game to the trash:
If you like the direction, I'd do it in small steps. The first PR would only move what main has today into Puppy, with no new options: brightness (kept across reboots, which #5 mentions is missing), Resize Home, Eject TF-2, and the power menu with the confirmation dialog in place of the Reboot and Power Off entries and are-you-sure. After that, one PR for each group of settings from my build, each one small enough to review on its own: volume and audio output, launcher view and tabs, language and font, the in-game overlay, date and time, power mode, the confirm button and the button tester. All of this is ready and tested on my console. As with my other PRs, I'd test each PR's own image on the device and say where AI was used.
And if you'd rather keep settings as separate apps, I can adapt these pages to that model instead. What do you think?
- Lingua principale
- C++
- Stelle
- 54
- Fork
- 8
- Merge medio
- 16g 19h
- PR unite (30g)
- 4
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di CodeZombie/goodluckOS
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 65/100
CodeZombie/goodluckOS#178 ·
-
TODO
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
CodeZombie/goodluckOS#12 ·
-
memory space or gamesAperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
CodeZombie/goodluckOS#177 · 1 commento ·
-
ME SALE SOFWARE DESCONOCIDOAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 25/100
CodeZombie/goodluckOS#176 ·
-
Appropriate names for gamesAperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 54/100
CodeZombie/goodluckOS#174 · 1 commento ·
Tutte le issue di CodeZombie/goodluckOS
Issue simili
-
needs-format
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
Niko1221/Strata#6251 · 1 commento ·
I maintainer di solito rispondono entro 5 giorni
-
[Bug]: NP 管理器文件编辑器里删除键无效Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
metasequoiaime/msime#11666 ·
I maintainer di solito rispondono entro 1 giorno
-
DAE2 crashes on call.without.effects with a non ref.func expressionForse già presa @stevenfontanella l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
WebAssembly/binaryen#9404 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
CVO-Org/immersive-cigs-rewrite#313 ·
I maintainer di solito rispondono entro 1 giorno
-
windows-latest (20261116.315.1) ships with incompatible MSVC (18.12) and pinned LLVM/Clang (20)Apertabug report
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
actions/runner-images#15367 · 4 commenti ·
I maintainer di solito rispondono entro 2 giorni