JDK types first reached by a source scan stay uninspected when any package is preloaded: `isFunctionalInterface()` is false for `PrivilegedAction`

クローズ
  • 何か問題がありますか？
#119 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
java
領域
backend

調査の方向性

Start by tracing ClassSymbolScanner.loadType(..., LAZILY) and the JavaInspectorImpl copy and commit loops described in the issue, then compare the preload and no-preload paths in the reproduction. Check how CompiledTypesManagerImpl.preload and on-demand inspection affect the type's inspection state. Done means the reproduced PrivilegedAction reports run() as its single abstract method and isFunctionalInterface() returns true after parsing with any preload.

索引モデルが issue の本文から書いたものです。

説明

Reproduction
SourceSet javaBase = SourceSetImpl.javaBase();
SourceSet sources = new SourceSetImpl.Builder().setName(JavaInspector.TEST_PROTOCOL)
        .setUri(URI.create("file:/")).setDependencies(List.of(javaBase)).build();
InputConfiguration config = new InputConfigurationImpl.Builder().addSourceSets(sources)
        .addClassPath("jmod:java.base").build();
JavaInspector ji = new io.codelaser.maddi.inspection.openjdk.JavaInspectorImpl();
ji.preload("java.base::java.util.");          // any preload; see the table below
ji.initialize(config);
TypeInfo x = ji.parse(Map.of("a.X", """
        package a;
        import java.security.PrivilegedAction;
        class X {
            static String m() {
                PrivilegedAction<String> action = () -> "x";
                return action.run();
            }
        }
        """), new JavaInspector.ParseOptions.Builder().build())
        .parseResult().primaryTypes().stream().findFirst().orElseThrow();
// visit m()'s body, take the Lambda, and inspect l.abstractFunctionalTypeInfo()
preloads PrivilegedAction after parse
none hasBeenInspected()=true, singleAbstractMethod()=run(), isFunctionalInterface()=true
java.base::java.util. hasBeenInspected()=false, singleAbstractMethod()=null, isFunctionalInterface()=false
java.base::java.util. + java.base::java.security hasBeenInspected()=true, run(), true

Seen on 0.9.5-alpha.11.

Expected

After parse returns, every type the parse result refers to answers member queries correctly, whatever was preloaded. Failing that, it should answer by completing the type on demand. A TypeInfo that silently reports "no single abstract method" while the parser has just resolved a lambda against it is the worst case: callers can't tell an uninspected type from a non-functional one.

Where it seems to come from

This is from reading the code; I haven't stepped through it.

  • ClassSymbolScanner.loadType(..., LAZILY) skips the members and setSingleAbstractMethod, and doesn't commit.
  • The type is completed later, by JavaInspectorImpl's "copy into CTM" loop. That loop commits scanned.primaryTypes(), classSymbolScanner().typesLoaded() (= infoByFqn.typesLoadedForThisSourceSet()), and the preloads.
  • With a preload, a shared-JDK task exists (preloadPass / wireSharedJdk). A platform type first reached during the source scan is then loaded on that shared task and registered for the JDK source set. It is not registered for the scanned set, so the loop never sees it. The preload pass's own commit loop has already run by then.
  • Without any preload there is no shared task, so the scanner's own typesLoaded() includes the type and it gets committed.
  • Also, CompiledTypesManagerImpl.preload is a TODO, and LAZILY-loaded types from the openjdk scanner don't register setOnDemandInspection. So TypeInfoImpl.inspection.get() returns the uncommitted builder instead of completing the type.
Impact

Code that branches on isFunctionalInterface() or singleAbstractMethod() for a lambda's or method reference's target type gets the wrong answer whenever that JDK interface wasn't covered by a preload. The same probably holds for any other member query on such a type (methods(), fields(), ...).

主要言語
Java
スター
1
フォーク
1
平均マージ
1時間 44分
マージ済み PR（30日）
6

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

CodeLaser/maddi のほかの issue

CodeLaser/maddi の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。