Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

JDK types first reached by a source scan stay uninspected when any package is preloaded: `isFunctionalInterface()` is false for `PrivilegedAction`

Cerrado
  • ¿Algo no está bien?
#119 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java
Área
backend

Línea de trabajo

Start by tracing ClassSymbolScanner.loadType(..., LAZILY) and the JavaInspectorImpl copy and commit loops described in the issue, then compare the preload and no-preload paths in the reproduction. Check how CompiledTypesManagerImpl.preload and on-demand inspection affect the type's inspection state. Done means the reproduced PrivilegedAction reports run() as its single abstract method and isFunctionalInterface() returns true after parsing with any preload.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Reproduction
SourceSet javaBase = SourceSetImpl.javaBase();
SourceSet sources = new SourceSetImpl.Builder().setName(JavaInspector.TEST_PROTOCOL)
        .setUri(URI.create("file:/")).setDependencies(List.of(javaBase)).build();
InputConfiguration config = new InputConfigurationImpl.Builder().addSourceSets(sources)
        .addClassPath("jmod:java.base").build();
JavaInspector ji = new io.codelaser.maddi.inspection.openjdk.JavaInspectorImpl();
ji.preload("java.base::java.util.");          // any preload; see the table below
ji.initialize(config);
TypeInfo x = ji.parse(Map.of("a.X", """
        package a;
        import java.security.PrivilegedAction;
        class X {
            static String m() {
                PrivilegedAction<String> action = () -> "x";
                return action.run();
            }
        }
        """), new JavaInspector.ParseOptions.Builder().build())
        .parseResult().primaryTypes().stream().findFirst().orElseThrow();
// visit m()'s body, take the Lambda, and inspect l.abstractFunctionalTypeInfo()
preloads PrivilegedAction after parse
none hasBeenInspected()=true, singleAbstractMethod()=run(), isFunctionalInterface()=true
java.base::java.util. hasBeenInspected()=false, singleAbstractMethod()=null, isFunctionalInterface()=false
java.base::java.util. + java.base::java.security hasBeenInspected()=true, run(), true

Seen on 0.9.5-alpha.11.

Expected

After parse returns, every type the parse result refers to answers member queries correctly, whatever was preloaded. Failing that, it should answer by completing the type on demand. A TypeInfo that silently reports "no single abstract method" while the parser has just resolved a lambda against it is the worst case: callers can't tell an uninspected type from a non-functional one.

Where it seems to come from

This is from reading the code; I haven't stepped through it.

  • ClassSymbolScanner.loadType(..., LAZILY) skips the members and setSingleAbstractMethod, and doesn't commit.
  • The type is completed later, by JavaInspectorImpl's "copy into CTM" loop. That loop commits scanned.primaryTypes(), classSymbolScanner().typesLoaded() (= infoByFqn.typesLoadedForThisSourceSet()), and the preloads.
  • With a preload, a shared-JDK task exists (preloadPass / wireSharedJdk). A platform type first reached during the source scan is then loaded on that shared task and registered for the JDK source set. It is not registered for the scanned set, so the loop never sees it. The preload pass's own commit loop has already run by then.
  • Without any preload there is no shared task, so the scanner's own typesLoaded() includes the type and it gets committed.
  • Also, CompiledTypesManagerImpl.preload is a TODO, and LAZILY-loaded types from the openjdk scanner don't register setOnDemandInspection. So TypeInfoImpl.inspection.get() returns the uncommitted builder instead of completing the type.
Impact

Code that branches on isFunctionalInterface() or singleAbstractMethod() for a lambda's or method reference's target type gets the wrong answer whenever that JDK interface wasn't covered by a preload. The same probably holds for any other member query on such a type (methods(), fields(), ...).

Lenguaje dominante
Java
Estrellas
1
Forks
1
Merge medio
2 h 22 min
PR fusionados (30 d)
4

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de CodeLaser/maddi

Todos los issues de CodeLaser/maddi

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.