Listen on Unix socket only; remove TCP listener and bring TypeScript to parity
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 45/100
調査の方向性
The issue involves three codebases: Go, Rust, and TypeScript. Start by examining the existing listener code in each (e.g., ts/src/index.ts:43 for TypeScript, and similar locations for Go and Rust). Understand how Unix socket listening is implemented in Go and Rust to add it to TypeScript. Review the integration suite in deploy/ to update from TCP to Unix socket. Check flag handling (--listen-tcp, --listen-socket) and systemd socket activation. Done means all three implementations listen only on Unix sockets, the TCP flag is removed, and tests pass with the updated configuration.
索引モデルが issue の本文から書いたものです。
説明
Is your feature request related to a problem?
The proxy currently accepts requests over TCP as well as a Unix socket, which breaks its own security model.
Access control in this project is built on socket ownership: a caller is authorised because it can connect(2) to a Unix socket whose filesystem permissions (user/group) the operator controls. A TCP listener has no equivalent — there is no peer uid/gid, so anything that can reach the port is implicitly trusted. --listen-tcp defaults to 127.0.0.1:2375, and deploy/docker-compose.yml binds 0.0.0.0:2375, so the weaker path is the one exercised by default.
This is already acknowledged as a one-sided rule: all three implementations reject tcp:// for the outbound connection to the Docker daemon (ts/src/flags.ts:42, Makefile:111) on exactly these grounds. The inbound listener never got the same treatment.
The three implementations are also not equivalent today, which contradicts the "equal peers" rule in AGENTS.md:
| Unix listener | TCP listener | |
|---|---|---|
| Go | yes | yes |
| Rust | yes | yes |
| TypeScript | no | yes |
TypeScript is TCP-only (ts/src/index.ts:43) and has no Unix socket support at all.
Describe the solution
Make Unix socket the only transport the proxy listens on, in all three implementations.
- Remove the
--listen-tcpflag and its listener from Go, Rust, and TypeScript. - Add Unix socket listening to TypeScript via
--listen-socket, reaching parity with Go and Rust, includingfd://3systemd socket activation and stale socket file cleanup. - Make a listen-socket bind failure fatal. With a single listener, a running-but-unbound process is never useful; today the bind error is logged and the process stays up.
- Migrate the integration suite (
deploy/docker-compose.yml,deploy/docker-compose.sock.yml,deploy/test.sh,deploy/test-sock.sh) fromtcp://proxy:2375to a shared-volume Unix socket. - Update
README.md(flag table and security boundary section) and the systemd example, which currently documentsListenStream=127.0.0.1:2375.
Describe alternatives
- Keep
--listen-tcpbut default it to disabled. Rejected: the insecure path stays reachable via config, and the security boundary stays advisory rather than structural. - Keep TCP and add peer authentication (mTLS). Rejected: substantially more surface and key management, to re-derive an identity the kernel already gives us for free over a Unix socket.
- Leave TypeScript TCP-only. Rejected: directly contradicts the equal-peers rule.
Which implementation(s) would this affect?
- Go
- Rust
- TypeScript
- Quint specification
- All
Additional context
Breaking change. Any deployment passing --listen-tcp or connecting via DOCKER_HOST=tcp://... must switch to a mounted Unix socket. The flag is removed outright rather than deprecated, so Go and Rust will exit on the unknown argument instead of silently listening on a socket the caller is not expecting.
The Quint spec models policy and invariants, not the transport layer, so no spec change is expected.
- 主要言語
- Rust
- スター
- 2
- フォーク
- 0
- 平均マージ
- 12時間 11分
- マージ済み PR(30日)
- 30
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
ChainSafe/docker-socket-policy のほかの issue
-
Type: Feature
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
ChainSafe/docker-socket-policy#65 ·
メンテナーはふだん 1 日以内に返信
-
Type: Enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 38/100
ChainSafe/docker-socket-policy#46 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
ChainSafe/docker-socket-policy の issue をすべて見る
似ている issue
-
Four problem loader browser tests fail on Windows対応中かも @Patriciaath999 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
starkware-libs/sequencer#15229 ·
メンテナーはふだん 1 日以内に返信
-
`fnox set` ignores piped stdin when `--description` is given, saving the secret without a valueオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
ActivityWatch/aw-notify-rs#47 · コメント 1 件 ·