Listen on Unix socket only; remove TCP listener and bring TypeScript to parity
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
Direzione di ricerca
The issue involves three codebases: Go, Rust, and TypeScript. Start by examining the existing listener code in each (e.g., ts/src/index.ts:43 for TypeScript, and similar locations for Go and Rust). Understand how Unix socket listening is implemented in Go and Rust to add it to TypeScript. Review the integration suite in deploy/ to update from TCP to Unix socket. Check flag handling (--listen-tcp, --listen-socket) and systemd socket activation. Done means all three implementations listen only on Unix sockets, the TCP flag is removed, and tests pass with the updated configuration.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is your feature request related to a problem?
The proxy currently accepts requests over TCP as well as a Unix socket, which breaks its own security model.
Access control in this project is built on socket ownership: a caller is authorised because it can connect(2) to a Unix socket whose filesystem permissions (user/group) the operator controls. A TCP listener has no equivalent — there is no peer uid/gid, so anything that can reach the port is implicitly trusted. --listen-tcp defaults to 127.0.0.1:2375, and deploy/docker-compose.yml binds 0.0.0.0:2375, so the weaker path is the one exercised by default.
This is already acknowledged as a one-sided rule: all three implementations reject tcp:// for the outbound connection to the Docker daemon (ts/src/flags.ts:42, Makefile:111) on exactly these grounds. The inbound listener never got the same treatment.
The three implementations are also not equivalent today, which contradicts the "equal peers" rule in AGENTS.md:
| Unix listener | TCP listener | |
|---|---|---|
| Go | yes | yes |
| Rust | yes | yes |
| TypeScript | no | yes |
TypeScript is TCP-only (ts/src/index.ts:43) and has no Unix socket support at all.
Describe the solution
Make Unix socket the only transport the proxy listens on, in all three implementations.
- Remove the
--listen-tcpflag and its listener from Go, Rust, and TypeScript. - Add Unix socket listening to TypeScript via
--listen-socket, reaching parity with Go and Rust, includingfd://3systemd socket activation and stale socket file cleanup. - Make a listen-socket bind failure fatal. With a single listener, a running-but-unbound process is never useful; today the bind error is logged and the process stays up.
- Migrate the integration suite (
deploy/docker-compose.yml,deploy/docker-compose.sock.yml,deploy/test.sh,deploy/test-sock.sh) fromtcp://proxy:2375to a shared-volume Unix socket. - Update
README.md(flag table and security boundary section) and the systemd example, which currently documentsListenStream=127.0.0.1:2375.
Describe alternatives
- Keep
--listen-tcpbut default it to disabled. Rejected: the insecure path stays reachable via config, and the security boundary stays advisory rather than structural. - Keep TCP and add peer authentication (mTLS). Rejected: substantially more surface and key management, to re-derive an identity the kernel already gives us for free over a Unix socket.
- Leave TypeScript TCP-only. Rejected: directly contradicts the equal-peers rule.
Which implementation(s) would this affect?
- Go
- Rust
- TypeScript
- Quint specification
- All
Additional context
Breaking change. Any deployment passing --listen-tcp or connecting via DOCKER_HOST=tcp://... must switch to a mounted Unix socket. The flag is removed outright rather than deprecated, so Go and Rust will exit on the unknown argument instead of silently listening on a socket the caller is not expecting.
The Quint spec models policy and invariants, not the transport layer, so no spec change is expected.
- Lingua principale
- Rust
- Stelle
- 2
- Fork
- 0
- Merge medio
- 9h 35m
- PR unite (30g)
- 6
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di ChainSafe/docker-socket-policy
-
Type: Documentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
-
Priority: P1 Type: Bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
-
Priority: P2 Type: Enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
-
Process exits 0 (Rust) / hangs (Go) when all listeners fail to bind — defeats Restart=on-failure ApertaPriority: P2 Type: Bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 65/100
-
Priority: P3 Type: Enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 64/100
Tutte le issue di ChainSafe/docker-socket-policy
Issue simili
-
bug github_actions
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
registrystack/registry-stack#1393 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
longbridge/gpui-kit#3223 ·
-
bug engine
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
rocky-data/rocky#2181 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
oasisprotocol/oasis-sdk#2523 ·
-
[indexer] [QA] Add a focused test for the new NonRetryableError / assertSocketAlive() behavior. Apertabot:ai-assisted component:indexer QA-roadmap status:untriaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
midnightntwrk/midnight-indexer#1557 ·