/shop add duplicates damaged, enchanted or renamed items

オープン
  • 何か問題がありますか？
#64 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
63/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
java
領域
backend

調査の方向性

Read InventoryManagementSystem.canRemove and its countQuantity logic, then trace how AddCommand removes items and how Transaction.process handles leftovers from addItem. Check the existing inventory tests and add coverage for damaged and renamed items during stock addition and purchases into partial stacks. Done when only eligible items are counted and removed, and inventory changes match the quantities recorded by the store.

索引モデルが issue の本文から書いたものです。

説明

bug

Problem

/shop add counts items by material, but removes them by exact match. A damaged, enchanted or renamed item passes the check, isn't removed from the player, and is still added to the store. This duplicates items.

InventoryManagementSystem.canRemove uses countQuantity, which only compares the material. AddCommand then calls removeItem(new ItemStack(material, quantity)), which only removes plain items, and ignores the leftovers it returns.

Steps to reproduce

  1. Have a store selling diamond_sword, and hold one damaged diamond sword.
  2. Run /shop add diamond_sword 1. The store's quantity goes up and the player keeps the damaged sword.
  3. Run /shop remove diamond_sword 1. The player now has two swords, one of them undamaged.

Reproduced in a test: one sword in the inventory became two.

Related

getAvailableSpace also counts partial stacks by material only, so space in a stack of renamed items is treated as free. On a real server addItem can't merge into those stacks, so a purchase could take the player's money and lose the items that didn't fit. Transaction.process ignores the leftovers from addItem. MockBukkit merged those stacks in testing, so this part comes from reading the code and should be confirmed on a test server.

Scope

  • Decide how non-plain items are treated. The simplest rule is that only plain items (matching a new ItemStack of that material) can be added.
  • Use the same rule when counting, checking space and removing items.

Done when

  • A damaged, enchanted or renamed item can't be added as plain stock, and the player's inventory always changes by exactly what the store records.
  • Tests cover damaged and renamed items for add, and for buying into partial stacks.
主要言語
Java
スター
1
フォーク
0
平均マージ
2時間 35分
マージ済み PR（30日）
14

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

BrendonButler/Shops のほかの issue

BrendonButler/Shops の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。