/shop add duplicates damaged, enchanted or renamed items

Abierto
  • ¿Algo no está bien?
#64 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
63/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
backend

Línea de trabajo

Read InventoryManagementSystem.canRemove and its countQuantity logic, then trace how AddCommand removes items and how Transaction.process handles leftovers from addItem. Check the existing inventory tests and add coverage for damaged and renamed items during stock addition and purchases into partial stacks. Done when only eligible items are counted and removed, and inventory changes match the quantities recorded by the store.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Problem

/shop add counts items by material, but removes them by exact match. A damaged, enchanted or renamed item passes the check, isn't removed from the player, and is still added to the store. This duplicates items.

InventoryManagementSystem.canRemove uses countQuantity, which only compares the material. AddCommand then calls removeItem(new ItemStack(material, quantity)), which only removes plain items, and ignores the leftovers it returns.

Steps to reproduce

  1. Have a store selling diamond_sword, and hold one damaged diamond sword.
  2. Run /shop add diamond_sword 1. The store's quantity goes up and the player keeps the damaged sword.
  3. Run /shop remove diamond_sword 1. The player now has two swords, one of them undamaged.

Reproduced in a test: one sword in the inventory became two.

Related

getAvailableSpace also counts partial stacks by material only, so space in a stack of renamed items is treated as free. On a real server addItem can't merge into those stacks, so a purchase could take the player's money and lose the items that didn't fit. Transaction.process ignores the leftovers from addItem. MockBukkit merged those stacks in testing, so this part comes from reading the code and should be confirmed on a test server.

Scope

  • Decide how non-plain items are treated. The simplest rule is that only plain items (matching a new ItemStack of that material) can be added.
  • Use the same rule when counting, checking space and removing items.

Done when

  • A damaged, enchanted or renamed item can't be added as plain stock, and the player's inventory always changes by exactly what the store records.
  • Tests cover damaged and renamed items for add, and for buying into partial stacks.
Lenguaje dominante
Java
Estrellas
1
Forks
0
Merge medio
2 h 35 min
PR fusionados (30 d)
14

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BrendonButler/Shops

Todos los issues de BrendonButler/Shops

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.