ENH: Add a bulk mask read to MaskCompare and use it for every mask read
メンテナーはふだん 6 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
Start with src/simplnx/Utilities/MaskCompareUtilities.hpp and .cpp to understand the existing mask interfaces, then inspect the listed OrientationAnalysis and SimplnxCore algorithms that bulk-read typed mask stores. Add a bulk read that reports transfer failures, route those algorithms through MaskCompare, and add the rule to docs/Code_Style_Guide.md. Done means in-core Release performance and out-of-core [ooc] tests meet the stated requirements.
索引モデルが issue の本文から書いたものです。
説明
Summary
Request: give MaskCompare a bulk read of a range of mask values that works for bool and uint8 masks, on in-memory and out-of-core stores, without making in-core algorithms slower. Then change every algorithm that reads a mask to read it through MaskCompare, instead of reading the typed mask stores itself.
Why: today a mask can be read in two different ways, and both are copied around the code base.
MaskCompare(MaskCompareUtilities.hpp) handlesboolanduint8masks behind one interface, but it reads one element at a time through the virtualisTrue(index),bothTrue()andbothFalse(). On an out-of-core store, each element read can load a whole chunk, so algorithms that are optimized for out-of-core data do not use it for their main loops.- Those algorithms read the mask in bulk instead. Each one checks whether the mask is a
UInt8Arrayor aBoolArray, callscopyIntoBuffer()on the matching store, and copies aboolmask through a contiguousboolscratch buffer, becausestd::vector<bool>is not contiguous. Each algorithm writes this branch itself. - A new algorithm then has to choose between a convenient helper that is slow out-of-core and a hand-written copy of the bulk pattern. Code that reads a mask only with
getDataAs<BoolArray>()getsnullptrfor auint8mask and silently ignores it.
Where it applies:
MaskCompare,BoolMaskCompare,UInt8MaskCompareandInstantiateMaskCompare()insrc/simplnx/Utilities/MaskCompareUtilities.hppand.cpp.- 27 files call
InstantiateMaskCompare()(at6dd86c67d). - These algorithms bulk-read the typed mask stores themselves. Several of them also use
MaskComparefor element access, and some handle only one of the two mask types. Each one needs to be checked:- OrientationAnalysis:
AlignSectionsMisorientation,AlignSectionsMutualInformation,BadDataNeighborOrientationCheckScanline,CAxisSegmentFeatures,ComputeFZQuaternions,EBSDSegmentFeatures,WriteStatsGenOdfAngleFile - SimplnxCore:
AlignSectionsFeatureCentroid,ComputeArrayHistogram,ComputeArrayHistogramByFeature,ComputeArrayStatistics,ComputeFeaturePhasesBinary,CreateColorMapScanline,DBSCANScanline,ErodeDilateMask,ExtractVertexGeometry
- OrientationAnalysis:
- Out-of-tree plugins, such as SimplnxReview, may contain the same pattern.
Requirements:
- The bulk read returns a
Resultfor a failed transfer. - In-core performance must not regress: compare the changed algorithms before and after in an in-core Release build.
- Out-of-core behavior must not regress: run the
[ooc]tests in the out-of-core build. - When
MaskComparehas the bulk read, add a rule todocs/Code_Style_Guide.mdthat algorithms read masks throughMaskCompare, in the same change.
The exact API (the signature of the bulk read, and whether it fills a uint8 or a bool buffer) is still open.
- 主要言語
- C++
- スター
- 18
- フォーク
- 15
- 平均マージ
- 4日 23時間
- マージ済み PR(30日)
- 42
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
BlueQuartzSoftware/simplnx のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
BlueQuartzSoftware/simplnx#1987 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
BlueQuartzSoftware/simplnx#1980 ·
メンテナーはふだん 6 日以内に返信
-
Testing
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
BlueQuartzSoftware/simplnx#1979 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
BlueQuartzSoftware/simplnx#1978 ·
メンテナーはふだん 6 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
BlueQuartzSoftware/simplnx#1945 ·
メンテナーはふだん 6 日以内に返信
BlueQuartzSoftware/simplnx の issue をすべて見る
似ている issue
-
bug triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信
-
26.04 bug dark-mode Easy Hack impress symptom: visual
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
CollaboraOnline/online#16421 · コメント 1 件 ·
-
area/cs bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
ydb-platform/ydb#59881 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
メンテナーはふだん 1 日以内に返信
-
documentation enhancement lua server
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100