ENH: Add a bulk mask read to MaskCompare and use it for every mask read
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start with src/simplnx/Utilities/MaskCompareUtilities.hpp and .cpp to understand the existing mask interfaces, then inspect the listed OrientationAnalysis and SimplnxCore algorithms that bulk-read typed mask stores. Add a bulk read that reports transfer failures, route those algorithms through MaskCompare, and add the rule to docs/Code_Style_Guide.md. Done means in-core Release performance and out-of-core [ooc] tests meet the stated requirements.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Request: give MaskCompare a bulk read of a range of mask values that works for bool and uint8 masks, on in-memory and out-of-core stores, without making in-core algorithms slower. Then change every algorithm that reads a mask to read it through MaskCompare, instead of reading the typed mask stores itself.
Why: today a mask can be read in two different ways, and both are copied around the code base.
MaskCompare(MaskCompareUtilities.hpp) handlesboolanduint8masks behind one interface, but it reads one element at a time through the virtualisTrue(index),bothTrue()andbothFalse(). On an out-of-core store, each element read can load a whole chunk, so algorithms that are optimized for out-of-core data do not use it for their main loops.- Those algorithms read the mask in bulk instead. Each one checks whether the mask is a
UInt8Arrayor aBoolArray, callscopyIntoBuffer()on the matching store, and copies aboolmask through a contiguousboolscratch buffer, becausestd::vector<bool>is not contiguous. Each algorithm writes this branch itself. - A new algorithm then has to choose between a convenient helper that is slow out-of-core and a hand-written copy of the bulk pattern. Code that reads a mask only with
getDataAs<BoolArray>()getsnullptrfor auint8mask and silently ignores it.
Where it applies:
MaskCompare,BoolMaskCompare,UInt8MaskCompareandInstantiateMaskCompare()insrc/simplnx/Utilities/MaskCompareUtilities.hppand.cpp.- 27 files call
InstantiateMaskCompare()(at6dd86c67d). - These algorithms bulk-read the typed mask stores themselves. Several of them also use
MaskComparefor element access, and some handle only one of the two mask types. Each one needs to be checked:- OrientationAnalysis:
AlignSectionsMisorientation,AlignSectionsMutualInformation,BadDataNeighborOrientationCheckScanline,CAxisSegmentFeatures,ComputeFZQuaternions,EBSDSegmentFeatures,WriteStatsGenOdfAngleFile - SimplnxCore:
AlignSectionsFeatureCentroid,ComputeArrayHistogram,ComputeArrayHistogramByFeature,ComputeArrayStatistics,ComputeFeaturePhasesBinary,CreateColorMapScanline,DBSCANScanline,ErodeDilateMask,ExtractVertexGeometry
- OrientationAnalysis:
- Out-of-tree plugins, such as SimplnxReview, may contain the same pattern.
Requirements:
- The bulk read returns a
Resultfor a failed transfer. - In-core performance must not regress: compare the changed algorithms before and after in an in-core Release build.
- Out-of-core behavior must not regress: run the
[ooc]tests in the out-of-core build. - When
MaskComparehas the bulk read, add a rule todocs/Code_Style_Guide.mdthat algorithms read masks throughMaskCompare, in the same change.
The exact API (the signature of the bulk read, and whether it fills a uint8 or a bool buffer) is still open.
- Lingua principale
- C++
- Stelle
- 18
- Fork
- 15
- Merge medio
- 4g 23h
- PR unite (30g)
- 42
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di BlueQuartzSoftware/simplnx
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
BlueQuartzSoftware/simplnx#1987 ·
I maintainer di solito rispondono entro 6 giorni
-
documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
BlueQuartzSoftware/simplnx#1980 ·
I maintainer di solito rispondono entro 6 giorni
-
Testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
BlueQuartzSoftware/simplnx#1979 ·
I maintainer di solito rispondono entro 6 giorni
-
documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
BlueQuartzSoftware/simplnx#1978 ·
I maintainer di solito rispondono entro 6 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
BlueQuartzSoftware/simplnx#1945 ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di BlueQuartzSoftware/simplnx
Issue simili
-
bug triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
-
26.04 bug dark-mode Easy Hack impress symptom: visual
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
CollaboraOnline/online#16421 · 1 commento ·
-
area/cs bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
ydb-platform/ydb#59881 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
I maintainer di solito rispondono entro 1 giorno
-
documentation enhancement lua server
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100