fix: restrict bot to configured channel's threads + future tag-based triggering across repos

オープン
#7 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@kpj2006 がすでに取り組んでいます。

2026年6月11日 から。

評価

この issue はまだ評価されていません。

説明

Summary

Currently the bot responds to messages in any thread across the entire server, not just threads that belong to the configured channel. This is a bug that needs to be fixed now, with a future enhancement to support tag-based triggering when the bot is deployed across multiple repos/servers.

Identified in: https://github.com/AOSSIE-Org/SkillBot/pull/6#discussion_r3393981241
Related PR: https://github.com/AOSSIE-Org/SkillBot/pull/6
Requested by: @kpj2006


Bug: Bot responds to ALL threads server-wide

Root Cause

In bot.py, the guard in process_message has a logic flaw:

is_in_thread = isinstance(message.channel, discord.Thread)
is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT

if not is_in_thread and not is_in_configured_channel:
    return

When message.channel is a discord.Thread, its .id is the thread's own ID, not the parent channel's ID. The condition not is_in_thread and not is_in_configured_channel lets all threads pass regardless of which channel they belong to, because is_in_thread being True skips the channel ID check entirely.

Fix for Current Codebase

In bot.py, update the process_message function (around lines 169–173):

     is_in_thread = isinstance(message.channel, discord.Thread)
-    is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT
+    if is_in_thread:
+        is_in_configured_channel = message.channel.parent_id == DISCORD_CHANNEL_ID_INT
+    else:
+        is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT

-    if not is_in_thread and not is_in_configured_channel:
+    if not is_in_configured_channel:
         return

This uses message.channel.parent_id when the channel is a Thread, which correctly identifies the parent text channel.


Future Enhancement: Tag-based Triggering Across Repos

In a later phase, the bot will be deployed across multiple Discord servers/repos and should only respond when explicitly mentioned/tagged (e.g., @SkillBot <question>).

Changes needed when implementing this:
  1. Add mention detection in process_message:

    • Check if client.user is mentioned in message.mentions before processing.
    • Strip the mention prefix from the message content before passing it to Ollama.
  2. Remove or relax the single-channel restriction (DISCORD_CHANNEL_ID_INT check):

    • Once tag-based triggering is in place, the bot can safely listen server-wide (or across guilds) since it only activates on explicit mentions.
  3. Update _get_or_create_thread:

    • Thread naming / parent channel logic may need to be generalized to work across any channel.
  4. Update .env / configuration:

    • DISCORD_CHANNEL_ID can be made optional or replaced with a list of allowed channels/guilds.
  5. Update on_ready backlog processing:

    • Backlog catch-up should also filter by mentions to avoid re-processing unrelated messages.
主要言語
Python
スター
10
フォーク
11
平均マージ
6分
マージ済み PR(30日)
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

AOSSIE-Org/SkillBot のほかの issue

AOSSIE-Org/SkillBot の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。