fix: restrict bot to configured channel's threads + future tag-based triggering across repos

Abierto
#7 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@kpj2006 ya está trabajando en esto.

Desde el 11/6/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Summary

Currently the bot responds to messages in any thread across the entire server, not just threads that belong to the configured channel. This is a bug that needs to be fixed now, with a future enhancement to support tag-based triggering when the bot is deployed across multiple repos/servers.

Identified in: https://github.com/AOSSIE-Org/SkillBot/pull/6#discussion_r3393981241
Related PR: https://github.com/AOSSIE-Org/SkillBot/pull/6
Requested by: @kpj2006


Bug: Bot responds to ALL threads server-wide

Root Cause

In bot.py, the guard in process_message has a logic flaw:

is_in_thread = isinstance(message.channel, discord.Thread)
is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT

if not is_in_thread and not is_in_configured_channel:
    return

When message.channel is a discord.Thread, its .id is the thread's own ID, not the parent channel's ID. The condition not is_in_thread and not is_in_configured_channel lets all threads pass regardless of which channel they belong to, because is_in_thread being True skips the channel ID check entirely.

Fix for Current Codebase

In bot.py, update the process_message function (around lines 169–173):

     is_in_thread = isinstance(message.channel, discord.Thread)
-    is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT
+    if is_in_thread:
+        is_in_configured_channel = message.channel.parent_id == DISCORD_CHANNEL_ID_INT
+    else:
+        is_in_configured_channel = message.channel.id == DISCORD_CHANNEL_ID_INT

-    if not is_in_thread and not is_in_configured_channel:
+    if not is_in_configured_channel:
         return

This uses message.channel.parent_id when the channel is a Thread, which correctly identifies the parent text channel.


Future Enhancement: Tag-based Triggering Across Repos

In a later phase, the bot will be deployed across multiple Discord servers/repos and should only respond when explicitly mentioned/tagged (e.g., @SkillBot <question>).

Changes needed when implementing this:
  1. Add mention detection in process_message:

    • Check if client.user is mentioned in message.mentions before processing.
    • Strip the mention prefix from the message content before passing it to Ollama.
  2. Remove or relax the single-channel restriction (DISCORD_CHANNEL_ID_INT check):

    • Once tag-based triggering is in place, the bot can safely listen server-wide (or across guilds) since it only activates on explicit mentions.
  3. Update _get_or_create_thread:

    • Thread naming / parent channel logic may need to be generalized to work across any channel.
  4. Update .env / configuration:

    • DISCORD_CHANNEL_ID can be made optional or replaced with a list of allowed channels/guilds.
  5. Update on_ready backlog processing:

    • Backlog catch-up should also filter by mentions to avoid re-processing unrelated messages.
Lenguaje dominante
Python
Estrellas
10
Forks
11
Merge medio
6 min
PR fusionados (30 d)
4

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AOSSIE-Org/SkillBot

Todos los issues de AOSSIE-Org/SkillBot

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.