Loom compatibility
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
Direzione di ricerca
Start by reviewing the repository’s synchronized blocks and methods, then check which can perform blocking operations and how JNI calls affect virtual thread pinning. The issue also points to OpenJDK’s virtual thread documentation and pgjdbc issue 1951 for context. Done means documenting Loom usage and performance implications, or identifying code changes that improve support; the issue does not specify a concrete test or implementation scope.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Wanted to check the status of this driver running with Loom (https://openjdk.org/projects/loom/).
As far as I understand, jdbc can generally benefit from running on virtual threads instead of actually blocking threads. So, I thought this would be useful for this jdbc driver, but I have not found any discussion about loom or virtual threads in this repo.
There seem to be two things to look out for though, because they can lead to still blocking threads with loom. Taken from the openjdk docs on virtual threads (https://openjdk.org/jeps/425):
There are two scenarios in which a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier:
When it executes code inside a synchronized block or method, or
When it executes a native method or a foreign function.
Pinning does not make an application incorrect, but it might hinder its scalability. If a virtual thread performs a blocking operation such as I/O or BlockingQueue.take() while it is pinned, then its carrier and the underlying OS thread are blocked for the duration of the operation. Frequent pinning for long durations can harm the scalability of an application by capturing carriers.
Doing a quick search in the repo for synchronized, I can see a few occurrences:
https://github.com/search?q=repo%3Axerial%2Fsqlite-jdbc+synchronized+language%3AJava&type=code&l=Java
The question is probably, which one of the synchronized blocks or methods actually contain blocking code and whether we can change them to a ReentrantLock (as proposed).
Another question I have is: We obviously rely on JNI to call the sqlite3 C api and there is no way around it. So I am guessing, this will unavoidably lead to thread pinning. Does anyone know more about that?
Is your feature request related to a problem? Please describe.
The problem for me is currently to understand, whether using this jdbc driver with a virtual thread executor makes sense, and whether we can do things to improve support.
Describe the solution you'd like
I can see two results:
- documentation on usage with loom and whether it can have a benfit on performance
- check whether we can do something in the code to improve support
Describe alternatives you've considered
Additional context
Relevant efforts done in pgjdbc for postgres: https://github.com/pgjdbc/pgjdbc/issues/1951
- Lingua principale
- Java
- Stelle
- 3.3k
- Fork
- 676
- Merge medio
- 1g 15h
- PR unite (30g)
- 18
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di xerial/sqlite-jdbc
-
triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
xerial/sqlite-jdbc#1515 ·
I maintainer di solito rispondono entro 1 giorno
-
triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
xerial/sqlite-jdbc#1514 ·
I maintainer di solito rispondono entro 1 giorno
-
triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
xerial/sqlite-jdbc#1513 ·
I maintainer di solito rispondono entro 1 giorno
-
triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
xerial/sqlite-jdbc#1512 ·
I maintainer di solito rispondono entro 1 giorno
-
SIGSEGV (exit 134) in bundled `rightstr()` when the length argument is a large negative numberForse già presa @sarthakdev143-lite l’ha presa 1 giorno fa. Apertahelp wanted impacts:JNI
Difficoltà 4/5 1-2 giorni Idoneità per principianti 38/100
xerial/sqlite-jdbc#1508 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di xerial/sqlite-jdbc
Issue simili
-
hermes-queue
Difficoltà 1/5 1-3 ore Idoneità per principianti 85/100
chrisalunlloyd2-sudo/mindpalace#403 ·
I maintainer di solito rispondono entro 1 giorno
-
Area/Configuration Type/Improvement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
ballerina-platform/static-code-analysis-tool#217 ·
I maintainer di solito rispondono entro 1 giorno
-
SequenceEncoder: a value ending with a backslash swallows the tokens after it (“No state for trait”)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
vassalengine/vassal#15337 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
eclipse-dirigible/dirigible#8636 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug severity-medium XS
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
nikolas-charalambidis/facepalm-maven-plugin#291 ·
I maintainer di solito rispondono entro 1 giorno