Loom compatibility
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start by reviewing the repository’s synchronized blocks and methods, then check which can perform blocking operations and how JNI calls affect virtual thread pinning. The issue also points to OpenJDK’s virtual thread documentation and pgjdbc issue 1951 for context. Done means documenting Loom usage and performance implications, or identifying code changes that improve support; the issue does not specify a concrete test or implementation scope.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Wanted to check the status of this driver running with Loom (https://openjdk.org/projects/loom/).
As far as I understand, jdbc can generally benefit from running on virtual threads instead of actually blocking threads. So, I thought this would be useful for this jdbc driver, but I have not found any discussion about loom or virtual threads in this repo.
There seem to be two things to look out for though, because they can lead to still blocking threads with loom. Taken from the openjdk docs on virtual threads (https://openjdk.org/jeps/425):
There are two scenarios in which a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier:
When it executes code inside a synchronized block or method, or
When it executes a native method or a foreign function.
Pinning does not make an application incorrect, but it might hinder its scalability. If a virtual thread performs a blocking operation such as I/O or BlockingQueue.take() while it is pinned, then its carrier and the underlying OS thread are blocked for the duration of the operation. Frequent pinning for long durations can harm the scalability of an application by capturing carriers.
Doing a quick search in the repo for synchronized, I can see a few occurrences:
https://github.com/search?q=repo%3Axerial%2Fsqlite-jdbc+synchronized+language%3AJava&type=code&l=Java
The question is probably, which one of the synchronized blocks or methods actually contain blocking code and whether we can change them to a ReentrantLock (as proposed).
Another question I have is: We obviously rely on JNI to call the sqlite3 C api and there is no way around it. So I am guessing, this will unavoidably lead to thread pinning. Does anyone know more about that?
Is your feature request related to a problem? Please describe.
The problem for me is currently to understand, whether using this jdbc driver with a virtual thread executor makes sense, and whether we can do things to improve support.
Describe the solution you'd like
I can see two results:
- documentation on usage with loom and whether it can have a benfit on performance
- check whether we can do something in the code to improve support
Describe alternatives you've considered
Additional context
Relevant efforts done in pgjdbc for postgres: https://github.com/pgjdbc/pgjdbc/issues/1951
- Lenguaje dominante
- Java
- Estrellas
- 3.3k
- Forks
- 676
- Merge medio
- 1 d 15 h
- PR fusionados (30 d)
- 18
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de xerial/sqlite-jdbc
-
triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
xerial/sqlite-jdbc#1515 ·
Los mantenedores suelen responder en 1 día
-
triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
xerial/sqlite-jdbc#1514 ·
Los mantenedores suelen responder en 1 día
-
triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
xerial/sqlite-jdbc#1513 ·
Los mantenedores suelen responder en 1 día
-
triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
xerial/sqlite-jdbc#1512 ·
Los mantenedores suelen responder en 1 día
-
SIGSEGV (exit 134) in bundled `rightstr()` when the length argument is a large negative numberPosiblemente ocupada @sarthakdev143-lite la tomó hace 2 días. Abiertohelp wanted impacts:JNI
Dificultad 4/5 1-2 días Aptitud para principiantes 38/100
xerial/sqlite-jdbc#1508 ·
Los mantenedores suelen responder en 1 día
Todos los issues de xerial/sqlite-jdbc
Issues similares
-
vips-drift
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Stirling-Tools/JPDFium#300 ·
Los mantenedores suelen responder en 1 día
-
hermes-queue
Dificultad 1/5 1-3 horas Aptitud para principiantes 85/100
chrisalunlloyd2-sudo/mindpalace#403 ·
Los mantenedores suelen responder en 1 día
-
Guidelines: document how to build a use case against a local, unpublished Flow/browserless-test changePosiblemente ocupada @totally-not-ai la tomó hoy. Abierto
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
vaadin/use-cases#452 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area/storage area/storage/sql
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Apicurio/apicurio-registry#11159 ·
Los mantenedores suelen responder en 1 día
-
Area/Configuration Type/Improvement
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
ballerina-platform/static-code-analysis-tool#217 ·
Los mantenedores suelen responder en 1 día