Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Sync workflow: handle a conflicting sync branch with no open PR, and PRs the workflow did not open

Aperta
  • Qualcosa non va?
#92 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github-actions, yaml
Ambito
ci-cd

Direzione di ricerca

Start with .github/workflows/sync-master-into-dev.yml: find where the merge conflict is handled and where the open PR is looked up by head branch chore/sync-master-into-dev. Related context is in #81, #68 and PR #90. Done means a conflict with no open sync PR opens one from the existing branch instead of exiting with a warning, and the workflow stops with a clear message when the branch or PR was not created by it. The ownership marker choice (label, hidden body marker, or author check) is still open, so confirm it with maintainers first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

CI enhancement

Description

Two edge cases in .github/workflows/sync-master-into-dev.yml (#81, for #70), raised by Qodo on the 0.10.1 release PR #90:

  1. A conflict with no open sync PR only produces a warning. If an earlier sync PR was closed without merging while chore/sync-master-into-dev kept unmerged commits, and a later master update conflicts with that branch, the workflow exits with an Actions warning and opens no PR. dev then drifts behind master silently, which is the situation the workflow exists to prevent (see #68).
  2. The PR is recognised by its head branch only. The workflow treats any open PR from chore/sync-master-into-dev to dev in this repository as its own and may retitle it, comment on it, or update the branch. #81 says "PRs the workflow didn't create are never touched"; strictly, a PR opened by hand from that same branch would be touched.

Both need unusual sequences (a closed-but-unmerged sync PR, or a hand-made PR from the bot's branch), so they are low priority.

Proposal

  • (1) When the merge conflicts and no sync PR is open, open one from the existing branch anyway, with instructions to resolve the conflict there, instead of exiting.
  • (2) Mark workflow-owned PRs durably (e.g. the branch-sync label plus a hidden marker in the body, and/or check the author is github-actions[bot]), and stop with a clear message if the branch or PR is not workflow-owned.
Lingua principale
C++
Stelle
21
Fork
8
Merge medio
7h 13m
PR unite (30g)
27

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di webarkit/WebARKitLib

Tutte le issue di webarkit/WebARKitLib

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.