Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Refactor shared editor-readiness tracking for remote export and review

Aperta
  • Qualcosa non va?
#1,111 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
electron, typescript
Ambito
desktop, devtools, testing

Direzione di ricerca

Start by comparing electron/mcp/remoteExport.ts and electron/mcp/reviewRecording.ts, then inspect their corresponding tests and the PR #1110 review thread for context. Identify the duplicated readiness and lifecycle behavior before locating the shared tracker’s appropriate module and test entry points. Done means both consumers share readiness state, meet the listed acceptance criteria, and their tracker and consumer tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

Extract the duplicated editor-readiness tracking from electron/mcp/remoteExport.ts and electron/mcp/reviewRecording.ts into a shared createEditorTracker({ ipc }) module.

This is a non-blocking maintainability follow-up to PR #1110. Requested by @deepak982. Keep this refactor separate from that PR.

Rationale

Both consumers maintain ready-editor maps, monitor editor lifecycle events, register remote-editor-ready listeners, and wait for an editor to report the requested recording path. Readiness-rule changes currently require updates in both modules.

Required changes

  • Move ready-editor tracking, path normalization, lifecycle monitoring, and the remote-editor-ready listener into the shared tracker.
  • Expose waitForEditor(videoPath, signal, cancelMessage).
  • Expose onEditorGone(editor, cb) so each consumer can settle its own pending request when its editor closes, crashes, or reloads.
  • Update remote export and recording review to use the tracker and remove their duplicated readiness logic.
  • Ensure both consumers share one tracker instance for the same IPC source rather than creating separate readiness maps and listeners.
  • Preserve each consumer's export or review behavior, cancellation messages, and timeout behavior.

Affected areas

  • electron/mcp/remoteExport.ts
  • electron/mcp/reviewRecording.ts
  • A new shared editor-readiness tracker module
  • Corresponding tracker, remote-export, and recording-review tests

Acceptance criteria

  • Remote export and recording review use shared readiness state and lifecycle monitoring.
  • Waiting resolves only for a live, non-crashed editor reporting the requested recording path.
  • Not-ready notifications and editor closure, crashes, or main-frame reloads clear readiness.
  • Editor disappearance settles the affected consumer's pending request.
  • Cancellation and timeout paths remove wait callbacks, timers, and abort listeners.
  • Tests cover the shared tracker and preserve existing remote-export and recording-review behavior.

References

Lingua principale
TypeScript
Stelle
32.4k
Fork
2.6k
Merge medio
5g 3h
PR unite (30g)
23

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di webadderallorg/Recordly

Tutte le issue di webadderallorg/Recordly

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.