Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Refactor shared editor-readiness tracking for remote export and review

Abierto
  • ¿Algo no está bien?
#1,111 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
electron, typescript
Área
desktop, devtools, testing

Línea de trabajo

Start by comparing electron/mcp/remoteExport.ts and electron/mcp/reviewRecording.ts, then inspect their corresponding tests and the PR #1110 review thread for context. Identify the duplicated readiness and lifecycle behavior before locating the shared tracker’s appropriate module and test entry points. Done means both consumers share readiness state, meet the listed acceptance criteria, and their tracker and consumer tests pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Extract the duplicated editor-readiness tracking from electron/mcp/remoteExport.ts and electron/mcp/reviewRecording.ts into a shared createEditorTracker({ ipc }) module.

This is a non-blocking maintainability follow-up to PR #1110. Requested by @deepak982. Keep this refactor separate from that PR.

Rationale

Both consumers maintain ready-editor maps, monitor editor lifecycle events, register remote-editor-ready listeners, and wait for an editor to report the requested recording path. Readiness-rule changes currently require updates in both modules.

Required changes

  • Move ready-editor tracking, path normalization, lifecycle monitoring, and the remote-editor-ready listener into the shared tracker.
  • Expose waitForEditor(videoPath, signal, cancelMessage).
  • Expose onEditorGone(editor, cb) so each consumer can settle its own pending request when its editor closes, crashes, or reloads.
  • Update remote export and recording review to use the tracker and remove their duplicated readiness logic.
  • Ensure both consumers share one tracker instance for the same IPC source rather than creating separate readiness maps and listeners.
  • Preserve each consumer's export or review behavior, cancellation messages, and timeout behavior.

Affected areas

  • electron/mcp/remoteExport.ts
  • electron/mcp/reviewRecording.ts
  • A new shared editor-readiness tracker module
  • Corresponding tracker, remote-export, and recording-review tests

Acceptance criteria

  • Remote export and recording review use shared readiness state and lifecycle monitoring.
  • Waiting resolves only for a live, non-crashed editor reporting the requested recording path.
  • Not-ready notifications and editor closure, crashes, or main-frame reloads clear readiness.
  • Editor disappearance settles the affected consumer's pending request.
  • Cancellation and timeout paths remove wait callbacks, timers, and abort listeners.
  • Tests cover the shared tracker and preserve existing remote-export and recording-review behavior.

References

Lenguaje dominante
TypeScript
Estrellas
32.4k
Forks
2.6k
Merge medio
5 d 10 h
PR fusionados (30 d)
21

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de webadderallorg/Recordly

Todos los issues de webadderallorg/Recordly

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.